* [powerpc:next-test 125/127] arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean
@ 2020-07-17 1:59 kernel test robot
2020-07-17 4:16 ` Aneesh Kumar K.V
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-07-17 1:59 UTC (permalink / raw)
To: Aneesh Kumar K.V; +Cc: linuxppc-dev, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3272 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test
head: 0fbd1eb4df96e1cbd039e0b95fdf62cf65a7faf9
commit: ed411c66eea2ccf93a634ae661a1f79c2bc63d88 [125/127] powerpc/book3s64/pkeys: Remove is_pkey_enabled()
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout ed411c66eea2ccf93a634ae661a1f79c2bc63d88
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
arch/powerpc/mm/book3s64/pkeys.c: In function 'pkey_access_permitted':
>> arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean 'arch_pkeys_enabled'? [-Werror=implicit-function-declaration]
392 | if (!is_pkey_enabled(pkey))
| ^~~~~~~~~~~~~~~
| arch_pkeys_enabled
cc1: some warnings being treated as errors
vim +392 arch/powerpc/mm/book3s64/pkeys.c
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 386
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 387 static bool pkey_access_permitted(int pkey, bool write, bool execute)
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 388 {
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 389 int pkey_shift;
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 390 u64 amr;
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 391
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 @392 if (!is_pkey_enabled(pkey))
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 393 return true;
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 394
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 395 pkey_shift = pkeyshift(pkey);
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 396 if (execute && !(read_iamr() & (IAMR_EX_BIT << pkey_shift)))
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 397 return true;
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 398
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 399 amr = read_amr(); /* Delay reading amr until absolutely needed */
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 400 return ((!write && !(amr & (AMR_RD_BIT << pkey_shift))) ||
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 401 (write && !(amr & (AMR_WR_BIT << pkey_shift))));
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 402 }
f2407ef3ba2256 arch/powerpc/mm/pkeys.c Ram Pai 2018-01-18 403
:::::: The code at line 392 was first introduced by commit
:::::: f2407ef3ba225665ee24965f69bc84435fb590cf powerpc: helper to validate key-access permissions of a pte
:::::: TO: Ram Pai <linuxram@us.ibm.com>
:::::: CC: Michael Ellerman <mpe@ellerman.id.au>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69525 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [powerpc:next-test 125/127] arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean
2020-07-17 1:59 [powerpc:next-test 125/127] arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean kernel test robot
@ 2020-07-17 4:16 ` Aneesh Kumar K.V
2020-07-18 12:47 ` Michael Ellerman
0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2020-07-17 4:16 UTC (permalink / raw)
To: kernel test robot; +Cc: linuxppc-dev, kbuild-all
On 7/17/20 7:29 AM, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test
> head: 0fbd1eb4df96e1cbd039e0b95fdf62cf65a7faf9
> commit: ed411c66eea2ccf93a634ae661a1f79c2bc63d88 [125/127] powerpc/book3s64/pkeys: Remove is_pkey_enabled()
> config: powerpc-allmodconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout ed411c66eea2ccf93a634ae661a1f79c2bc63d88
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> arch/powerpc/mm/book3s64/pkeys.c: In function 'pkey_access_permitted':
>>> arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean 'arch_pkeys_enabled'? [-Werror=implicit-function-declaration]
> 392 | if (!is_pkey_enabled(pkey))
> | ^~~~~~~~~~~~~~~
> | arch_pkeys_enabled
> cc1: some warnings being treated as errors
>
> vim +392 arch/powerpc/mm/book3s64/pkeys.c
>
We removed that upstream in
19ab500edb5d6020010caba48ce3b4ce4182ab63 powerpc/mm/pkeys: Make pkey
access check work on execute_only_key
next-test need to be rebased?
-aneesh
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [powerpc:next-test 125/127] arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean
2020-07-17 4:16 ` Aneesh Kumar K.V
@ 2020-07-18 12:47 ` Michael Ellerman
0 siblings, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2020-07-18 12:47 UTC (permalink / raw)
To: Aneesh Kumar K.V, kernel test robot; +Cc: linuxppc-dev, kbuild-all
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:
> On 7/17/20 7:29 AM, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next-test
>> head: 0fbd1eb4df96e1cbd039e0b95fdf62cf65a7faf9
>> commit: ed411c66eea2ccf93a634ae661a1f79c2bc63d88 [125/127] powerpc/book3s64/pkeys: Remove is_pkey_enabled()
>> config: powerpc-allmodconfig (attached as .config)
>> compiler: powerpc64-linux-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> git checkout ed411c66eea2ccf93a634ae661a1f79c2bc63d88
>> # save the attached .config to linux build tree
>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>> arch/powerpc/mm/book3s64/pkeys.c: In function 'pkey_access_permitted':
>>>> arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean 'arch_pkeys_enabled'? [-Werror=implicit-function-declaration]
>> 392 | if (!is_pkey_enabled(pkey))
>> | ^~~~~~~~~~~~~~~
>> | arch_pkeys_enabled
>> cc1: some warnings being treated as errors
>>
>> vim +392 arch/powerpc/mm/book3s64/pkeys.c
>>
>
>
> We removed that upstream in
>
> 19ab500edb5d6020010caba48ce3b4ce4182ab63 powerpc/mm/pkeys: Make pkey
> access check work on execute_only_key
>
> next-test need to be rebased?
I don't rebase next onto master.
I'll merge fixes prior to applying your series.
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-18 12:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-17 1:59 [powerpc:next-test 125/127] arch/powerpc/mm/book3s64/pkeys.c:392:7: error: implicit declaration of function 'is_pkey_enabled'; did you mean kernel test robot
2020-07-17 4:16 ` Aneesh Kumar K.V
2020-07-18 12:47 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).