From: "John Rigby" <jcrigby@gmail.com>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: Scott Wood <scottwood@freescale.com>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] MPC5121 FEC support
Date: Tue, 17 Jun 2008 18:55:55 -0600 [thread overview]
Message-ID: <4b73d43f0806171755u7ea8e965rbb62e74559f676c0@mail.gmail.com> (raw)
In-Reply-To: <20080618103549.06110799.sfr@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Tue, Jun 17, 2008 at 6:35 PM, Stephen Rothwell <sfr@canb.auug.org.au>
wrote:
> Hi John,
>
> You should factor out the fec_t -> struct fec change into an earlier
> patch of its own.
Ok, I'll separate that from the checkpatch fixes.
>
>
> On Tue, 17 Jun 2008 11:48:00 -0600 John Rigby <jrigby@freescale.com>
> wrote:
> >
> > +++ b/drivers/net/fs_enet/fec_mpc5121.h
>
> > +#include <asm/cpm.h>
>
>
> Nothing in this file uses anything in asm/cpm.h, so it shouldn't be
> included here.
Ok.
>
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/ <http://www.canb.auug.org.au/%7Esfr/>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
[-- Attachment #2: Type: text/html, Size: 1892 bytes --]
prev parent reply other threads:[~2008-06-18 0:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 17:48 [PATCH] MPC5121 FEC support John Rigby
2008-06-17 18:01 ` Scott Wood
2008-06-18 0:35 ` Stephen Rothwell
2008-06-18 0:55 ` John Rigby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b73d43f0806171755u7ea8e965rbb62e74559f676c0@mail.gmail.com \
--to=jcrigby@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).