From: "John Rigby" <jcrigby@gmail.com>
To: michael@ellerman.id.au
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] powerpc: pci config cleanup
Date: Wed, 25 Jun 2008 21:32:21 -0600 [thread overview]
Message-ID: <4b73d43f0806252032p15d390c9g177c74705564211@mail.gmail.com> (raw)
In-Reply-To: <1214441634.32022.2.camel@localhost>
Thanks Michael, your explanation makes things make more sense. I was
just a half intelligent monkey trying to replicate the existing logic.
I think your explanation also answers Ben's question also.
On Wed, Jun 25, 2008 at 6:53 PM, Michael Ellerman
<michael@ellerman.id.au> wrote:
> On Wed, 2008-06-25 at 14:19 -0600, John Rigby wrote:
>> change
>> bool "PCI support" if <long ugly expression>
>> to
>> bool "PCI support" if PPC_HAS_PCI
>>
>> and add select PPC_HAS_PCI to all the config nodes that
>> were previously in the PCI if expression
>>
>> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
>> index 3934e26..fa9bd91 100644
>> --- a/arch/powerpc/Kconfig
>> +++ b/arch/powerpc/Kconfig
>> @@ -542,11 +542,12 @@ config FSL_LBC
>> config MCA
>> bool
>>
>> +config PPC_HAS_PCI
>> + bool
>> +
>> config PCI
>> - bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \
>> - || PPC_MPC52xx || (EMBEDDED && (PPC_PSERIES || PPC_ISERIES)) \
>> - || PPC_PS3 || 44x
>> - default y if !40x && !CPM2 && !8xx && !PPC_MPC512x && !PPC_83xx \
>> + bool "PCI support" if PPC_HAS_PCI
>> + default y if !40x && !CPM2 && !8xx && !PPC_83xx \
>> && !PPC_85xx && !PPC_86xx
>> default PCI_PERMEDIA if !4xx && !CPM2 && !8xx
>> default PCI_QSPAN if !4xx && !CPM2 && 8xx
>
> This is backward I think. The bool says whether you get to choose if you
> have PCI, not if you have it. It should be called CAN_CHOOSE_PCI or
> something.
>
> For example this makes no sense:
>
>> diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig
>> index 07fe5b6..e205066 100644
>> --- a/arch/powerpc/platforms/pseries/Kconfig
>> +++ b/arch/powerpc/platforms/pseries/Kconfig
>> @@ -7,6 +7,7 @@ config PPC_PSERIES
>> select RTAS_ERROR_LOGGING
>> select PPC_UDBG_16550
>> select PPC_NATIVE
>> + select PPC_HAS_PCI if EMBEDDED
>
>
> cheers
>
> --
> Michael Ellerman
> OzLabs, IBM Australia Development Lab
>
> wwweb: http://michael.ellerman.id.au
> phone: +61 2 6212 1183 (tie line 70 21183)
>
> We do not inherit the earth from our ancestors,
> we borrow it from our children. - S.M.A.R.T Person
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
prev parent reply other threads:[~2008-06-26 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 20:19 [PATCH 0/2] powerpc: pci cleanup John Rigby
2008-06-25 20:19 ` [PATCH 1/2] powerpc: pci config cleanup John Rigby
2008-06-25 20:19 ` [PATCH 2/2] powerpc: Move mpc83xx_add_bridge to fsl_pci.c John Rigby
2008-06-25 22:53 ` [PATCH 1/2] powerpc: pci config cleanup Benjamin Herrenschmidt
2008-06-26 0:53 ` Michael Ellerman
2008-06-26 3:32 ` John Rigby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b73d43f0806252032p15d390c9g177c74705564211@mail.gmail.com \
--to=jcrigby@gmail.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).