From: "John Rigby" <jcrigby@gmail.com>
To: "Grant Likely" <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support
Date: Sun, 29 Jun 2008 22:01:08 -0600 [thread overview]
Message-ID: <4b73d43f0806292101v21192746v54bebcb2a3919bab@mail.gmail.com> (raw)
In-Reply-To: <20080629053646.GC13876@secretlab.ca>
On Sat, Jun 28, 2008 at 11:36 PM, Grant Likely
<grant.likely@secretlab.ca> wrote:
> Minor comments below.
>
> On Fri, Jun 20, 2008 at 10:58:37AM -0600, John Rigby wrote:
>> Add a interrupt host for the interrupt
>> controller in the mpc5121ads cpld.
>> PCI interrupts are 0-7 the rest are 8-15
>> Touchscreen pendown irq is hardwired to irq1
>> All other irqs are chainged to irq0
>>
>> Signed-off-by: John Rigby <jrigby@freescale.com>
>> ---
>> arch/powerpc/platforms/512x/Kconfig | 1 +
>> arch/powerpc/platforms/512x/Makefile | 2 +-
>> arch/powerpc/platforms/512x/mpc5121_ads.c | 14 ++-
>> arch/powerpc/platforms/512x/mpc5121_ads.h | 14 ++
>> arch/powerpc/platforms/512x/mpc5121_ads_cpld.c | 204 ++++++++++++++++++++++++
>> 5 files changed, 233 insertions(+), 2 deletions(-)
>> create mode 100644 arch/powerpc/platforms/512x/mpc5121_ads.h
>> create mode 100644 arch/powerpc/platforms/512x/mpc5121_ads_cpld.c
>>
>> diff --git a/arch/powerpc/platforms/512x/Kconfig b/arch/powerpc/platforms/512x/Kconfig
>> index f9a04da..0fd3b00 100644
>> --- a/arch/powerpc/platforms/512x/Kconfig
>> +++ b/arch/powerpc/platforms/512x/Kconfig
>> @@ -12,6 +12,7 @@ config MPC5121_ADS
>> depends on PPC_MULTIPLATFORM && PPC32
>> select DEFAULT_UIMAGE
>> select PPC_MPC5121
>> + select MPC5121_ADS_CPLD
>
> What is this for? I don't see it used anywhere.
Yes you are right, the Makefile just uses MPC5121_ADS to include the cpld code.
>
>> help
>> This option enables support for the MPC5121E ADS board.
>>
>> diff --git a/arch/powerpc/platforms/512x/mpc5121_ads.c b/arch/powerpc/platforms/512x/mpc5121_ads.c
>> index 45bb2ef..36805fd 100644
>> --- a/arch/powerpc/platforms/512x/mpc5121_ads.c
>> +++ b/arch/powerpc/platforms/512x/mpc5121_ads.c
>> @@ -1,5 +1,5 @@
>> /*
>> - * Copyright (C) 2007 Freescale Semiconductor, Inc. All rights reserved.
>> + * Copyright (C) 2007, 2008 Freescale Semiconductor, Inc. All rights reserved.
>> *
>> * Author: John Rigby, <jrigby@freescale.com>, Thur Mar 29 2007
>> *
>> @@ -23,6 +23,16 @@
>> #include <asm/time.h>
>>
>> #include "mpc512x.h"
>> +#include "mpc5121_ads.h"
>> +
>> +static void __init mpc5121_ads_setup_arch(void)
>> +{
>> + printk(KERN_INFO "MPC5121 ADS board from Freescale Semiconductor\n");
>> + /*
>> + * cpld regs are needed early
>> + */
>> + mpc5121_ads_cpld_map();
>> +}
>>
>> static struct of_device_id __initdata of_bus_ids[] = {
>> { .name = "soc", },
>> @@ -41,6 +51,7 @@ static void __init mpc5121_ads_declare_of_platform_devices(void)
>> static void __init mpc5121_ads_init_IRQ(void)
>> {
>> mpc512x_init_IRQ();
>> + mpc5121_ads_cpld_pic_init();
>
> Ah, I understand now. Ignore my related comment in the previous patch.
>
>> }
>>
>> /*
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
next prev parent reply other threads:[~2008-06-30 4:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 16:58 [PATCH 0/6] MPC5121 Updates John Rigby
[not found] ` <1213981119-1979-2-git-send-email-jrigby@freescale.com>
2008-06-20 16:58 ` [PATCH 2/6] MPC5121 clock driver John Rigby
2008-06-20 16:58 ` [PATCH 3/6] MPC5121 Add generic board support John Rigby
2008-06-20 16:58 ` [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support John Rigby
2008-06-20 16:58 ` [PATCH 5/6] MPC5121 Add PCI support John Rigby
2008-06-20 16:58 ` [PATCH 6/6] MPC5121 Hide pci bridge John Rigby
2008-06-29 5:42 ` Grant Likely
2008-06-20 22:03 ` [PATCH 5/6] MPC5121 Add PCI support Kumar Gala
2008-06-20 22:17 ` Scott Wood
2008-06-29 5:38 ` Grant Likely
2008-06-30 3:59 ` John Rigby
2008-06-29 5:36 ` [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support Grant Likely
2008-06-30 4:01 ` John Rigby [this message]
2008-06-29 5:30 ` [PATCH 3/6] MPC5121 Add generic board support Grant Likely
2008-06-21 4:39 ` [PATCH 2/6] MPC5121 clock driver Stephen Rothwell
2008-06-29 5:21 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b73d43f0806292101v21192746v54bebcb2a3919bab@mail.gmail.com \
--to=jcrigby@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).