From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.228]) by ozlabs.org (Postfix) with ESMTP id BFF87DDF7B for ; Fri, 8 May 2009 12:12:56 +1000 (EST) Received: by rv-out-0506.google.com with SMTP id f9so901097rvb.9 for ; Thu, 07 May 2009 19:12:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1241640919-4650-1-git-send-email-wd@denx.de> <1241640919-4650-9-git-send-email-wd@denx.de> <20090506221908.3927583420E8@gemini.denx.de> Date: Thu, 7 May 2009 20:12:54 -0600 Message-ID: <4b73d43f0905071912k4bcc8821nabfa27aa5b1f587b@mail.gmail.com> Subject: Re: [PATCH 08/12] mpc5121: Added I2C support. From: John Rigby To: Grant Likely Content-Type: multipart/alternative; boundary=000e0cd32e0aa0ba5a04695d2a11 Cc: linux-i2c@vger.kernel.org, linuxppc-dev@ozlabs.org, Wolfgang Denk , Detlev Zundel , Piotr Ziecik List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --000e0cd32e0aa0ba5a04695d2a11 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Ok, the interrupt enabling should happen in the driver. Should it key off compatible or should a new property be added like the existing 5200 clocking property? On Wed, May 6, 2009 at 8:41 PM, Grant Likely wrote: > On Wed, May 6, 2009 at 4:51 PM, Grant Likely > wrote: > > On Wed, May 6, 2009 at 4:19 PM, Wolfgang Denk wrote: > >> Dear Grant Likely, > >> > >> In message > you wrote: > >>> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk wrote: > >>> > From: Piotr Ziecik > >>> > > >>> > - Enabled I2C interrupts on MPC5121. > >>> > - Updated Kconfig for i2c-mpc driver. > >>> > >>> I think this workaround belongs in the driver itself. > >> > >> Sorry, I don't get it. Which workaround? What exactly should I change? > > > > Sorry, I misread the patch. Never mind. > > Actually, on 3rd reading, I think my first impression was correct > (even if I was wrong about it being a workaround). This code in > mpc512x_init_i2c() is only relevant for i2c busses (it isn't shared > with any other drivers). Therefore, it belongs with the i2c bus > itself. It does not belong in platform code. > > Cheers, > g. > > -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > --000e0cd32e0aa0ba5a04695d2a11 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Ok, the interrupt enabling should happen in the driver.=A0 Should it key of= f compatible or should a new property be added like the existing 5200 clock= ing property?

On Wed, May 6, 2009 at 8:41= PM, Grant Likely <grant.likely@secretlab.ca> wrote:
On Wed, May 6, 2009 at 4:51 PM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Wed, May 6, 2009 at 4:19 PM, Wolfgang Denk <wd@denx.de> wrote:
>> Dear Grant Likely,
>>
>> In message <fa686aa40905061401k319313c5q89fd3e245c30808f@ma= il.gmail.com> you wrote:
>>> On Wed, May 6, 2009 at 2:15 PM, Wolfgang Denk <wd@denx.de> wrote:
>>> > From: Piotr Ziecik <kosmo@semihalf.com>
>>> >
>>> > - Enabled I2C interrupts on MPC5121.
>>> > - Updated Kconfig for i2c-mpc driver.
>>>
>>> I think this workaround belongs in the driver itself.
>>
>> Sorry, I don't get it. Which workaround? What exactly should I= change?
>
> Sorry, I misread the patch. =A0Never mind.

Actually, on 3rd reading, I think my first impression was correct
(even if I was wrong about it being a workaround). =A0This code in
mpc512x_init_i2c() is only relevant for i2c busses (it isn't shared
with any other drivers). =A0Therefore, it belongs with the i2c bus
itself. =A0It does not belong in platform code.

Cheers,
g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

--000e0cd32e0aa0ba5a04695d2a11--