From: Geoff Levand <geoff@infradead.org>
To: Leonard Goehrs <l.goehrs@pengutronix.de>,
u.kleine-koenig@pengutronix.de, perex@perex.cz, tiwai@suse.com,
mpe@ellerman.id.au
Cc: alsa-devel@alsa-project.org, paulus@samba.org,
kernel@pengutronix.de, Geert Uytterhoeven <geert@linux-m68k.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe
Date: Fri, 27 Nov 2020 11:39:51 -0800 [thread overview]
Message-ID: <4b84b78f-1173-c357-da3e-02c9c347aa61@infradead.org> (raw)
In-Reply-To: <20201127152259.1470079-1-l.goehrs@pengutronix.de>
On 11/27/20 7:22 AM, Leonard Goehrs wrote:
> The check for the FW_FEATURE_PS3_LV1 firmware feature is already performed
> in ps3_system_bus_init() before registering the driver. So if the probe
> function is actually used, this feature is already known to be available.
>
> The check for the match id is also superfluous; the condition is always
> true because the bus' match function (ps3_system_bus_match()) only
> considers this driver for devices having:
> dev->match_id == snd_ps3_bus_driver_info.match_id.
>
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Leonard Goehrs <l.goehrs@pengutronix.de>
Seems OK with v5.9 on PS3.
Tested by: Geoff Levand <geoff@infradead.org>
next prev parent reply other threads:[~2020-11-27 19:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 16:59 [PATCH 1/2] ALSA: ppc: drop if block with always false condition Uwe Kleine-König
2020-11-26 16:59 ` [PATCH 2/2] powerpc/ps3: make system bus's remove and shutdown callbacks return void Uwe Kleine-König
2020-11-26 17:44 ` Uwe Kleine-König
2020-11-27 8:40 ` Geert Uytterhoeven
2020-11-27 19:39 ` Geoff Levand
2020-11-28 8:48 ` Takashi Iwai
2020-11-29 17:31 ` Uwe Kleine-König
2020-12-02 12:14 ` Michael Ellerman
2020-12-02 12:22 ` Takashi Iwai
2020-11-27 8:35 ` [PATCH 1/2] ALSA: ppc: drop if block with always false condition Geert Uytterhoeven
2020-11-27 9:45 ` Uwe Kleine-König
2020-11-27 15:22 ` [PATCH] ALSA: ppc: remove redundant checks in PS3 driver probe Leonard Goehrs
2020-11-27 17:34 ` Uwe Kleine-König
2020-11-27 19:39 ` Geoff Levand [this message]
2020-11-28 8:49 ` Takashi Iwai
2020-11-27 19:37 ` [PATCH 1/2] ALSA: ppc: drop if block with always false condition Geoff Levand
2020-11-28 8:48 ` Takashi Iwai
2020-12-10 11:30 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b84b78f-1173-c357-da3e-02c9c347aa61@infradead.org \
--to=geoff@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=geert@linux-m68k.org \
--cc=kernel@pengutronix.de \
--cc=l.goehrs@pengutronix.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).