From: Segher Boessenkool <segher@kernel.crashing.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Linux PPC Dev ML <linuxppc-dev@ozlabs.org>,
Sylvain Munaut <tnt@246tNt.com>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 02/10] powerpc: Add device tree fixups for the EFIKA
Date: Fri, 16 Feb 2007 17:44:54 +0100 [thread overview]
Message-ID: <4c862ff39a26802e96af9b5932a447c3@kernel.crashing.org> (raw)
In-Reply-To: <1171326015.20192.44.camel@localhost.localdomain>
>> The const might cause a warning because prop_set_prop takes a void
>> *value and not
>> a const void *value. I don't know if does need to modify the value or
>> not though.
>
> Ok, there's room for another patch to constify prom_set_prop and all
> callers then :-)
No callers should need changing. If they do then that's
some bonus bugs fixed ;-)
>> I would have hoped that being local to a __init function the memory
>> for
>> the initial values would be freed but I might me over optimistic.
>
> Yeah, worth checking the ELF output but I think you are over
> optimistic :-)
There is nothing that makes data in a function in
the .init.text section automagically end up in the
.init.data section -- those names are just names,
for all the tools involved, with no attached meaning.
Segher
next prev parent reply other threads:[~2007-02-16 16:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 22:13 [PATCH 00/10] Mainly 52xx patches for 2.6.21 (but not only) Sylvain Munaut
2007-02-12 22:13 ` [PATCH 01/10] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Sylvain Munaut
2007-02-12 22:13 ` [PATCH 02/10] powerpc: Add device tree fixups for the EFIKA Sylvain Munaut
2007-02-12 22:13 ` [PATCH 03/10] powerpc: Restore 'proper' link order in platform Sylvain Munaut
2007-02-12 22:13 ` [PATCH 04/10] powerpc: Use common 52xx of_platform probe code for EFIKA Sylvain Munaut
2007-02-12 22:13 ` [PATCH 05/10] powerpc: Fix unbalanced of_node_{get, put} in efika-setup.c Sylvain Munaut
2007-02-12 22:13 ` [PATCH 06/10] powerpc: Small cleanup of EFIKA platform Sylvain Munaut
2007-02-12 22:13 ` [PATCH 07/10] powerpc: Add a unified uevent handler for bus based on of_device Sylvain Munaut
2007-02-12 22:13 ` [PATCH 08/10] macintosh: Use the new of_device common uevent handler Sylvain Munaut
2007-02-12 22:13 ` [PATCH 09/10] powerpc: Add uevent handler for of_platform_bus Sylvain Munaut
2007-02-12 22:13 ` [PATCH 10/10] powerpc: Add uevent handler for ibmebus Sylvain Munaut
2007-03-29 14:46 ` Olaf Hering
2007-03-30 11:27 ` Hoang-Nam Nguyen
2007-03-30 11:45 ` Sylvain Munaut
2007-03-27 6:30 ` [PATCH 08/10] macintosh: Use the new of_device common uevent handler Benjamin Herrenschmidt
2007-03-27 7:11 ` Sylvain Munaut
2007-03-28 10:29 ` Johannes Berg
2007-03-28 10:58 ` Sylvain Munaut
2007-03-28 11:10 ` Johannes Berg
2007-02-12 23:06 ` [PATCH 02/10] powerpc: Add device tree fixups for the EFIKA Kumar Gala
2007-02-12 23:11 ` Sylvain Munaut
2007-02-12 23:18 ` Benjamin Herrenschmidt
2007-02-12 23:12 ` Benjamin Herrenschmidt
2007-02-12 23:25 ` Sylvain Munaut
2007-02-13 0:20 ` Benjamin Herrenschmidt
2007-02-16 16:44 ` Segher Boessenkool [this message]
2007-02-12 23:10 ` [PATCH 01/10] powerpc/serial: Dispose irq mapping when done in mpc52xx_serial.c Benjamin Herrenschmidt
2007-02-15 22:18 ` [PATCH] " Sylvain Munaut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c862ff39a26802e96af9b5932a447c3@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).