From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/3] First cut at PReP support for arch/powerpc
Date: Mon, 6 Aug 2007 21:42:34 +0200 [thread overview]
Message-ID: <4d4b2d7064b052024d37a11a580e51a6@kernel.crashing.org> (raw)
In-Reply-To: <20070803063532.GB14456@localhost.localdomain>
>>> + PIC8259: interrupt-controller {
>>> + device_type = "i8259";
>>>
>>> device_type = "interrupt-controller".
>
> Is that really right? The MPIC binding, at least, has device_type =
> "open-pic" rather than "interrupt-controller".
I got confused. "open-pic" as device_type is nonsense, because
it doesn't define anything an OF can work with itself. However,
since some older interrupt controller bindings (pre-imap) define
a device_type, the interrupt mapping recommended practice had to
work around this, so it specified an empty "interrupt-controller"
property for all interrupt controller nodes.
I don't know what the specified device_type for 8259s is; it
seems to me you don't need it in a flat device tree at all.
>>> + MPIC: interrupt-controller@d {
>>> + device_type = "open-pic";
>>>
>>> device_type = "interrupt-controller".
>
> Not according to the binding in booting-without-of.txt
Yeah, mea culpa. Again, you can just leave it out I think.
Segher
next prev parent reply other threads:[~2007-08-06 19:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-27 6:53 [PATCH 0/3] PReP support David Gibson
2007-06-27 6:54 ` [PATCH 2/3] Make more OF-related bootwrapper functions available to non-OF platforms David Gibson
2007-06-28 8:44 ` Segher Boessenkool
2007-06-27 6:54 ` [PATCH 1/3] Abolish unused ucBoardRev variables David Gibson
2007-06-27 7:10 ` [PATCH 3/3] First cut at PReP support for arch/powerpc David Gibson
2007-06-27 11:22 ` Milton Miller
2007-06-27 11:29 ` udbg_16550.c and legacy_serial.c Milton Miller
2007-06-28 0:38 ` [PATCH 3/3] First cut at PReP support for arch/powerpc David Gibson
2007-06-28 8:59 ` Segher Boessenkool
2007-06-28 10:00 ` Gabriel Paubert
2007-07-02 11:51 ` Segher Boessenkool
2007-07-03 9:51 ` Gabriel Paubert
2007-07-03 12:49 ` Segher Boessenkool
2007-07-03 2:26 ` Tom Gall
2007-07-03 6:50 ` Ulrich Teichert
2007-08-03 6:35 ` David Gibson
2007-08-03 15:24 ` Jon Loeliger
2007-08-06 19:43 ` Segher Boessenkool
2007-08-06 19:42 ` Segher Boessenkool [this message]
2007-07-18 1:31 ` David Gibson
2007-07-18 15:55 ` Segher Boessenkool
2007-08-03 6:43 ` David Gibson
2007-08-06 19:37 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2007-08-03 21:55 Yoder Stuart-B08248
2007-08-06 4:02 ` David Gibson
2007-08-06 19:45 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d4b2d7064b052024d37a11a580e51a6@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).