From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55EA0C54E67 for ; Wed, 27 Mar 2024 22:09:16 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=RmfHP7AK; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4V4gn66Tflz3vc6 for ; Thu, 28 Mar 2024 09:09:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=RmfHP7AK; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sifive.com (client-ip=2607:f8b0:4864:20::d2d; helo=mail-io1-xd2d.google.com; envelope-from=samuel.holland@sifive.com; receiver=lists.ozlabs.org) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4V4gmG3J7qz3cG3 for ; Thu, 28 Mar 2024 09:08:29 +1100 (AEDT) Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-7cc0b35b75bso10477439f.3 for ; Wed, 27 Mar 2024 15:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1711577306; x=1712182106; darn=lists.ozlabs.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bmkqc/3aYewIsupa3aI44uZjMZk6uVE6sk1O51xM5oE=; b=RmfHP7AKBHF4upzo6KdxG4+kipMU5Tnfkj+s7m6qSHEfhAcJmbW55u1tJhncpU5qrz IIb3GYt+kU1NM9iEd3XivVivx0lyeMxoljW6r/KzqL7jvOc1V5t0JvnyLxxMPk2rWe8h GCUmRUTVpDGsAAZnOGqn2TvisUghOJuSx4P9QdJQoVzP5G6Otqm6FnfszCszNYepF1m1 W9K5wWDWEfc3KoasD2L5EtSOuu+OZoCchE583YKG9LoYoCKnJ/JNGUMsyePel4p+gKhv vNqjo/hpYxyFqTqS9ca55N6nRl71cQfKmPnfNaLB8vJO7dKqjcNXTtVfs4SBockjiaMZ 2ZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711577306; x=1712182106; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bmkqc/3aYewIsupa3aI44uZjMZk6uVE6sk1O51xM5oE=; b=WAuljQOjYeWcVSK1nv2+B89D1y9ThGfKNsPN7aFXSv1MNckzEQIzHN/52dWyTTj0ic WJlMfHDqSOuzL6W4jbhod7Qs0CaEHz5Nr6692eUf+aVW3U/ivcSfTeI238DEwp5cUwRW mReoVJ6FQmbUVtkKumCZOnFioUV6DD+RdMcqqDoHZ2J1zWPNlM01DGkc/njwWVkuKB6W jH3+4jIWB8uj4nDorKw/SIDpbku1fK2XY+yeVQ72XgEm3Su63vu7qDuwaUFX82p5V8/3 8TKC3kgg88vK4LTZy62eF+4Wv4nev/P7TwOMOAMViXbeoUzWPDKFYpFA5oi0GMrWUVGp tzeQ== X-Forwarded-Encrypted: i=1; AJvYcCX55b6bZCnhBhosRpANq6JaQQG4NdxByAXgXYdAJJab/D/FVdFSfJX05EZbZv1wHAwPWbmh360RzH3j/H0/oGOnRbRUF9KIpxZOrVmmqA== X-Gm-Message-State: AOJu0YwcK7rzrLYcEtW3L+wZ96HJaScqgLFyj0vPWWuyIKj5+NJ4hceJ 84Hp+hdJNP9T3PpGzfXmQ1jJt4amshtVOtDQBO5DzgzQW24i4MHa5MDZpFXo9M8= X-Google-Smtp-Source: AGHT+IGUYm3Y8wBDca1kE2cHOU4Wfjx7H338gBLx60QGaDb6jbN+3GFHHCGUs0OMGF33wA7wIsUyRw== X-Received: by 2002:a6b:f919:0:b0:7cb:ffd8:1546 with SMTP id j25-20020a6bf919000000b007cbffd81546mr1424618iog.19.1711577305709; Wed, 27 Mar 2024 15:08:25 -0700 (PDT) Received: from [100.64.0.1] ([170.85.6.190]) by smtp.gmail.com with ESMTPSA id f12-20020a056638118c00b0047bea529fddsm2373jas.104.2024.03.27.15.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 15:08:25 -0700 (PDT) Message-ID: <4d9633cd-15c4-4cc1-ac67-2592e9fc7880@sifive.com> Date: Wed, 27 Mar 2024 17:08:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/14] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Andrew Morton References: <20240327200157.1097089-1-samuel.holland@sifive.com> <20240327200157.1097089-13-samuel.holland@sifive.com> <20240327142516.e4b1f9ba6e2ec7bc300e4d58@linux-foundation.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <20240327142516.e4b1f9ba6e2ec7bc300e4d58@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, loongarch@lists.linux.dev, Alex Deucher , linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2024-03-27 4:25 PM, Andrew Morton wrote: > On Wed, 27 Mar 2024 13:00:43 -0700 Samuel Holland wrote: > >> Now that all previously-supported architectures select >> ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead >> of the existing list of architectures. It can also take advantage of the >> common kernel-mode FPU API and method of adjusting CFLAGS. >> >> ... >> >> @@ -87,16 +78,9 @@ void dc_fpu_begin(const char *function_name, const int line) >> WARN_ON_ONCE(!in_task()); >> preempt_disable(); >> depth = __this_cpu_inc_return(fpu_recursion_depth); >> - >> if (depth == 1) { >> -#if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH) >> + BUG_ON(!kernel_fpu_available()); >> kernel_fpu_begin(); > > For some reason kernel_fpu_available() was undefined in my x86_64 > allmodconfig build. I just removed the statement. This is because the include guard in asm/fpu.h conflicts with the existing one in asm/fpu/types.h (which doesn't match its filename), so the definition of kernel_fpu_available() is not seen. I can fix up the include guard in asm/fpu/types.h in the next version: diff --git a/arch/x86/include/asm/fpu/types.h b/arch/x86/include/asm/fpu/types.h index ace9aa3b78a3..75a3910d867a 100644 --- a/arch/x86/include/asm/fpu/types.h +++ b/arch/x86/include/asm/fpu/types.h @@ -2,8 +2,8 @@ /* * FPU data structures: */ -#ifndef _ASM_X86_FPU_H -#define _ASM_X86_FPU_H +#ifndef _ASM_X86_FPU_TYPES_H +#define _ASM_X86_FPU_TYPES_H #include @@ -596,4 +596,4 @@ struct fpu_state_config { /* FPU state configuration information */ extern struct fpu_state_config fpu_kernel_cfg, fpu_user_cfg; -#endif /* _ASM_X86_FPU_H */ +#endif /* _ASM_X86_FPU_TY{ES_H */ Regards, Samuel