[PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

[PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

[Danny Tsen]

Data mismatch found when testing ipsec tunnel with AES/GCM crypto.
Disabling CRYPTO_AES_GCM_P10 in Kconfig for this feature.

Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")

Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
---
 arch/powerpc/crypto/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig
index 09ebcbdfb34f..46a4c85e85e2 100644
--- a/arch/powerpc/crypto/Kconfig
+++ b/arch/powerpc/crypto/Kconfig
@@ -107,6 +107,7 @@ config CRYPTO_AES_PPC_SPE
 
 config CRYPTO_AES_GCM_P10
 	tristate "Stitched AES/GCM acceleration support on P10 or later CPU (PPC)"
+	depends on BROKEN
 	depends on PPC64 && CPU_LITTLE_ENDIAN && VSX
 	select CRYPTO_LIB_AES
 	select CRYPTO_ALGAPI
-- 
2.43.0

Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

[Kamlesh Gurudasani]

Danny Tsen <dtsen@linux.ibm.com> writes:

> Data mismatch found when testing ipsec tunnel with AES/GCM crypto.
> Disabling CRYPTO_AES_GCM_P10 in Kconfig for this feature.
>
> Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
> Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
> Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
>
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
nitpick
checkpatch complains
Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' -
ie: 'Fixes: 45a4672b9a6e ("crypto: p10-aes-gcm - Update Kconfig and
Makefile")'

There is no rule for 12 characters, but it is generally preferred.
I guess it is just a typo for you as you have correctly added other
Fixes tag.

If you end up re-spinning, please correct this

Also, just to understand,

"A Fixes: tag indicates that the patch fixes an issue in a previous
 commit. It is used to make it easy to determine where a bug originated,
 which can help review a bug fix"

from 
https://docs.kernel.org/process/submitting-patches.html

should there not be just single Fixes tag? as bug originated from one
commit, may be the commit that actually broke the functionality.

P.S.
Not expert on this, just trying to learn.

Kamlesh

Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1852 bytes --]

Hi Kamlesh,

On Fri, 20 Sep 2024 15:07:19 +0530 Kamlesh Gurudasani <kamlesh@ti.com> wrote:
>
> Danny Tsen <dtsen@linux.ibm.com> writes:
> 
> > Data mismatch found when testing ipsec tunnel with AES/GCM crypto.
> > Disabling CRYPTO_AES_GCM_P10 in Kconfig for this feature.
> >
> > Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
> > Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
> > Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
> >
> > Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>  
> nitpick
> checkpatch complains
> Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' -
> ie: 'Fixes: 45a4672b9a6e ("crypto: p10-aes-gcm - Update Kconfig and
> Makefile")'
> 
> There is no rule for 12 characters, but it is generally preferred.
> I guess it is just a typo for you as you have correctly added other
> Fixes tag.

It should be at least 12 hex digits i.e. more is fine.  It is possible
that some commits need more than 12 hex digits of the SHA1 to be
uniquely identified in some git repositories already.  I guess
checkpatch needs a patch.

> Also, just to understand,
> 
> "A Fixes: tag indicates that the patch fixes an issue in a previous
>  commit. It is used to make it easy to determine where a bug originated,
>  which can help review a bug fix"
> 
> from 
> https://docs.kernel.org/process/submitting-patches.html
> 
> should there not be just single Fixes tag? as bug originated from one
> commit, may be the commit that actually broke the functionality.

While we generally prefer that a patch only fix one bug, it is very
possible that the bug may have been introduced in more than one commit
e.g. in different files.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

[Herbert Xu]

On Thu, Sep 19, 2024 at 07:36:37AM -0400, Danny Tsen wrote:
> Data mismatch found when testing ipsec tunnel with AES/GCM crypto.
> Disabling CRYPTO_AES_GCM_P10 in Kconfig for this feature.
> 
> Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
> Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
> Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
> 
> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
> ---
>  arch/powerpc/crypto/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3] crypto: Removing CRYPTO_AES_GCM_P10.

[Danny Tsen]

Thanks Herbert.

-Danny

On 9/21/24 4:31 AM, Herbert Xu wrote:
> On Thu, Sep 19, 2024 at 07:36:37AM -0400, Danny Tsen wrote:
>> Data mismatch found when testing ipsec tunnel with AES/GCM crypto.
>> Disabling CRYPTO_AES_GCM_P10 in Kconfig for this feature.
>>
>> Fixes: fd0e9b3e2ee6 ("crypto: p10-aes-gcm - An accelerated AES/GCM stitched implementation")
>> Fixes: cdcecfd9991f ("crypto: p10-aes-gcm - Glue code for AES/GCM stitched implementation")
>> Fixes: 45a4672b9a6e2 ("crypto: p10-aes-gcm - Update Kconfig and Makefile")
>>
>> Signed-off-by: Danny Tsen <dtsen@linux.ibm.com>
>> ---
>>   arch/powerpc/crypto/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
> Patch applied.  Thanks.