linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: Joel Stanley <joel@jms.id.au>, Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/perf: Quiet PMU registration message
Date: Tue, 9 Oct 2018 11:31:02 +0530	[thread overview]
Message-ID: <4e599d64-53dd-fcc0-39ca-2cb7bdd9134f@linux.vnet.ibm.com> (raw)
In-Reply-To: <20181009055444.20317-1-joel@jms.id.au>



On Tuesday 09 October 2018 11:24 AM, Joel Stanley wrote:
> On a Power9 box we get a few screens full of these on boot. Drop
> them to pr_debug.
>
> [    5.993645] nest_centaur6_imc performance monitor hardware support registered
> [    5.993728] nest_centaur7_imc performance monitor hardware support registered
> [    5.996510] core_imc performance monitor hardware support registered
> [    5.996569] nest_mba0_imc performance monitor hardware support registered
> [    5.996631] nest_mba1_imc performance monitor hardware support registered
> [    5.996685] nest_mba2_imc performance monitor hardware support registered
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>   arch/powerpc/perf/core-book3s.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c
> index 81f8a0c838ae..a01c521694e8 100644
> --- a/arch/powerpc/perf/core-book3s.c
> +++ b/arch/powerpc/perf/core-book3s.c
> @@ -2249,8 +2249,8 @@ int register_power_pmu(struct power_pmu *pmu)
>   		return -EBUSY;		/* something's already registered */
>
>   	ppmu = pmu;
> -	pr_info("%s performance monitor hardware support registered\n",
> -		pmu->name);
> +	pr_debug("%s performance monitor hardware support registered\n",
> +		 pmu->name);

We should have this message since this is for CPU PMU.
But we can imc once. Something like this


diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c
index 1fafc32b12a0..6954636b16d1 100644
--- a/arch/powerpc/perf/imc-pmu.c
+++ b/arch/powerpc/perf/imc-pmu.c
@@ -1392,7 +1392,7 @@ int init_imc_pmu(struct device_node *parent, 
struct imc_pmu *pmu_ptr, int pmu_id
      if (ret)
          goto err_free_cpuhp_mem;

-    pr_info("%s performance monitor hardware support registered\n",
+    pr_debug("%s performance monitor hardware support registered\n",
                              pmu_ptr->pmu.name);

      return 0;


Maddy

>   	power_pmu.attr_groups = ppmu->attr_groups;
>


      reply	other threads:[~2018-10-09  6:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09  5:54 [PATCH] powerpc/perf: Quiet PMU registration message Joel Stanley
2018-10-09  6:01 ` Madhavan Srinivasan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e599d64-53dd-fcc0-39ca-2cb7bdd9134f@linux.vnet.ibm.com \
    --to=maddy@linux.vnet.ibm.com \
    --cc=joel@jms.id.au \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).