From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8E3F107637F for ; Wed, 1 Apr 2026 14:11:07 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fm6NB43Kjz2yhY; Thu, 02 Apr 2026 01:11:06 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c0a:e001:78e:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775052666; cv=none; b=O6LEpXmkz8J++0lwAJwV8NixsSarlOE5z1kxjums4iMK3MXD+bViI/ORbV5OzJfMAAcKIUIGb31+pgoaTOPzGqWQmre4RQRQs6Y6ke4FkJ42clYBP1kUBnBE9yuRarf5+HJEZq42VqmI7bs+134nDYEHVnIC/ZlkKfdiX+pFTEvQIg/LKXZZ1aNgG4gIZvsT9iGdolAIWJU/PIjPkeNcF1U7dj3KXuDRDazUYRESd0FgyfPFQ950hYA2gsNBDfTvvwaDrj/NXMKjAlZHDBoiT4DkhllHJgGbB2azDxGfgIWRpWDq11IpiBVKyqV0dcTxCAFQh1XYq8rAdi02NhNdew== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775052666; c=relaxed/relaxed; bh=ihs7ql9+V7i2jsV+Fz+TOoJH9NgFzocVSWGjd1tnnG8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MRw1B+un5TVWnzx/LEz6/gfkixYRiZnp2aG4sm+PUNqwofI7HqxXAepXmkuR89DVEkKh2VFb9aM8mGZD0F0PR9UMqk6e8+dkLIwXCHafemXZscoqr45DbP+kNtYKHURktSXVKCX56tbZPAftneXnaletwlmR8yC/l0XDaWPW/igHI3GI9y6w/+fQi5KfmJlBX54SCtz4eeS7w6Lojh8QVftF+h25SAV6mJrJRmarx0u0EVTDvuqnhyGa7OOLaUgJNl72WPD6t+3AWSgfFEGfhpPdlQj6wd6PQHW6LDPvS1rskrZY/JWMG4pSiMhMv9++G+b3d7emvB5THO0cikiXmg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EVtkVC0K; dkim-atps=neutral; spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=david@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EVtkVC0K; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org; envelope-from=david@kernel.org; receiver=lists.ozlabs.org) Received: from sea.source.kernel.org (sea.source.kernel.org [IPv6:2600:3c0a:e001:78e:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fm6N340dVz2xd6 for ; Thu, 02 Apr 2026 01:10:59 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id B91324089F; Wed, 1 Apr 2026 14:10:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA854C19421; Wed, 1 Apr 2026 14:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775052657; bh=y9AZ3kPGoHublxbM40WNj5WyT0fJ5pu6ZSBg2xxPUXM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=EVtkVC0K0I6FJox73TKW/Bx7q/dEY4tNpkzJoZqc9VoM5MX9GOTFVnOQ9eqLz7fTt xHfpZyN+DdIdzs6aSCnUdS1E1rzPqX9K0cGIS2P/lcAtjkq/xMbunYz4Wt8JJwHoAK Pq9g8E9qiPs5uVsSD6ZO1tsAcA39t6bDwU69m5irmlIpXRpIXKk1z+OcMIybSlMQdy s9QC1w3DFHiUJ0kgQbcJwM/7C6S6H4fVS0ehb8yhaACrRMOK7AQo5m4DksLS1tjxGD 2M4hyTLZUbmibYBR4DjVRPy/3ENNUFj0yHk5v+FJL+XF9SSCdboUk5MuMJp4Y1fen2 zDQyJktu+qzLw== Message-ID: <4e859cfa-db79-4676-9509-81a2140db3f3@kernel.org> Date: Wed, 1 Apr 2026 16:10:51 +0200 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 06/13] selftest/mm: adjust hugepage-mremap test size for large huge pages To: Sayali Patil , Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Ritesh Harjani Cc: Zi Yan , Michal Hocko , Oscar Salvador , Lorenzo Stoakes , Dev Jain , Liam.Howlett@oracle.com, linuxppc-dev@lists.ozlabs.org, Venkat Rao Bagalkote References: From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/27/26 08:16, Sayali Patil wrote: > The hugepage-mremap selftest uses a default size of 10MB, which is > sufficient for small huge page sizes. However, when the huge page size > is large (e.g. 1GB), 10MB is smaller than a single huge page. > As a result, the test does not trigger PMD sharing and the > corresponding unshare path in mremap(), causing the > test to fail (mremap succeeds where a failure is expected). > > Update run_vmtest.sh to use twice the huge page size when the huge page > size exceeds 10MB, while retaining the 10MB default for smaller huge > pages. This ensures the test exercises the intended PMD sharing and > unsharing paths for larger huge page sizes. > > Before patch: > running ./hugepage-mremap > ------------------------------ > TAP version 13 > 1..1 > Map haddr: Returned address is 0x7eaa40000000 > Map daddr: Returned address is 0x7daa40000000 > Map vaddr: Returned address is 0x7faa40000000 > Address returned by mmap() = 0x7fffaa600000 > Mremap: Returned address is 0x7faa40000000 > First hex is 0 > First hex is 3020100 > Bail out! mremap: Expected failure, but call succeeded > Planned tests != run tests (1 != 0) > Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 > [FAIL] > not ok 1 hugepage-mremap # exit=1 > > Before patch: > running ./hugepage-mremap > ------------------------------ > TAP version 13 > 1..1 > Map haddr: Returned address is 0x7eaa40000000 > Map daddr: Returned address is 0x7daa40000000 > Map vaddr: Returned address is 0x7faa40000000 > Address returned by mmap() = 0x7fffaa600000 > Mremap: Returned address is 0x7faa40000000 > First hex is 0 > First hex is 3020100 > Bail out! mremap: Expected failure, but call succeeded > Planned tests != run tests (1 != 0) > Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 > [FAIL] > not ok 1 hugepage-mremap # exit=1 > Why are there two "Before patch" in here? > After patch: > running ./hugepage-mremap 2048 > ------------------------------ > TAP version 13 > 1..1 > Map haddr: Returned address is 0x7eaa40000000 > Map daddr: Returned address is 0x7daa40000000 > Map vaddr: Returned address is 0x7faa40000000 > Address returned by mmap() = 0x7fff13000000 > Mremap: Returned address is 0x7faa40000000 > First hex is 0 > First hex is 3020100 > ok 1 Read same data > Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 > [PASS] > ok 1 hugepage-mremap 2048 > > Fixes: f77a286de48c ("mm, hugepages: make memory size variable in hugepage-mremap selftest") > Acked-by: Zi Yan > Tested-by: Venkat Rao Bagalkote > Signed-off-by: Sayali Patil > --- > tools/testing/selftests/mm/run_vmtests.sh | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index afdcfd0d7cef..eecec0b6eb13 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -293,7 +293,18 @@ echo "$shmmax" > /proc/sys/kernel/shmmax > echo "$shmall" > /proc/sys/kernel/shmall > > CATEGORY="hugetlb" run_test ./map_hugetlb > -CATEGORY="hugetlb" run_test ./hugepage-mremap > + > +# If the huge page size is larger than 10MB, increase the test memory size > +# to twice the huge page size (in MB) to ensure the test exercises PMD sharing > +# and the unshare path in hugepage-mremap. Otherwise, run the test with > +# the default 10MB memory size. PMD sharing requires, on x86, a 1 GiB area with 2 MiB hugetlb folios. How does doubling sort that out? Also, why the magic value 10mb? -- Cheers, David