PPC64 TOC. warnings

PPC64 TOC. warnings

[Randy Dunlap]

Hi,

I'm seeing thousands of these warnings:
(gcc 12.2.0)


./include/generated/autoksyms.h:7:9: warning: ISO C99 requires whitespace after the macro name
    7 | #define __KSYM_TOC. 1
      |         ^~~~~~~~~~

In file included from ../include/asm-generic/export.h:57,
                 from ./arch/powerpc/include/generated/asm/export.h:1,
                 from ../arch/powerpc/kernel/misc.S:17:
./include/generated/autoksyms.h:7:9: warning: missing whitespace after the macro name
    7 | #define __KSYM_TOC. 1
      |         ^~~~~~~~~~


Can anything be done about them?

Thanks.
-- 
~Randy

Re: PPC64 TOC. warnings

[Masahiro Yamada]

On Sun, Feb 5, 2023 at 2:30 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> Hi,
>
> I'm seeing thousands of these warnings:
> (gcc 12.2.0)
>
>
> ./include/generated/autoksyms.h:7:9: warning: ISO C99 requires whitespace after the macro name
>     7 | #define __KSYM_TOC. 1
>       |         ^~~~~~~~~~
>
> In file included from ../include/asm-generic/export.h:57,
>                  from ./arch/powerpc/include/generated/asm/export.h:1,
>                  from ../arch/powerpc/kernel/misc.S:17:
> ./include/generated/autoksyms.h:7:9: warning: missing whitespace after the macro name
>     7 | #define __KSYM_TOC. 1
>       |         ^~~~~~~~~~
>
>
> Can anything be done about them?
>
> Thanks.
> --
> ~Randy



Hmm, I just thought this issue was fixed by
commit 29500f15b54b63ad0ea60b58e85144262bd24df2



Does this happen only for GCC 12?

Does the following patch fix the issue?
(I did not test it.)





diff --git a/scripts/gen_autoksyms.sh b/scripts/gen_autoksyms.sh
index 12bcfae940ee..70d4ab3621f6 100755
--- a/scripts/gen_autoksyms.sh
+++ b/scripts/gen_autoksyms.sh
@@ -54,7 +54,7 @@ EOT
 } | sed -e 's/ /\n/g' | sed -n -e '/^$/!p' |
 # Remove the dot prefix for ppc64; symbol names with a dot (.) hold entry
 # point addresses.
-sed -e 's/^\.//' |
+sed -e 's/^\.//g' |
 sort -u |
 # Ignore __this_module. It's not an exported symbol, and will be resolved
 # when the final .ko's are linked.










-- 
Best Regards
Masahiro Yamada

Re: PPC64 TOC. warnings

[Randy Dunlap]

On 2/4/23 09:40, Masahiro Yamada wrote:
> On Sun, Feb 5, 2023 at 2:30 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> Hi,
>>
>> I'm seeing thousands of these warnings:
>> (gcc 12.2.0)
>>
>>
>> ./include/generated/autoksyms.h:7:9: warning: ISO C99 requires whitespace after the macro name
>>     7 | #define __KSYM_TOC. 1
>>       |         ^~~~~~~~~~
>>
>> In file included from ../include/asm-generic/export.h:57,
>>                  from ./arch/powerpc/include/generated/asm/export.h:1,
>>                  from ../arch/powerpc/kernel/misc.S:17:
>> ./include/generated/autoksyms.h:7:9: warning: missing whitespace after the macro name
>>     7 | #define __KSYM_TOC. 1
>>       |         ^~~~~~~~~~
>>
>>
>> Can anything be done about them?
>>
>> Thanks.
>> --
>> ~Randy
> 
> 
> 
> Hmm, I just thought this issue was fixed by
> commit 29500f15b54b63ad0ea60b58e85144262bd24df2
> 
> 
> 
> Does this happen only for GCC 12?
> 
> Does the following patch fix the issue?
> (I did not test it.)
> 
> 

I have been running build tests all day (have probably done around 500 builds)
and I'm not seeing the build problem now. I don't know why not or what changed.

I have not applied the patch below. I'm just trying to reproduce the problem
and cannot do so. (Bad me: I had 3 build failures earlier but I didn't save the
failing .config files! I didn't think that it would be so difficult to reproduce.)

Thanks for your help.

> 
> 
> 
> diff --git a/scripts/gen_autoksyms.sh b/scripts/gen_autoksyms.sh
> index 12bcfae940ee..70d4ab3621f6 100755
> --- a/scripts/gen_autoksyms.sh
> +++ b/scripts/gen_autoksyms.sh
> @@ -54,7 +54,7 @@ EOT
>  } | sed -e 's/ /\n/g' | sed -n -e '/^$/!p' |
>  # Remove the dot prefix for ppc64; symbol names with a dot (.) hold entry
>  # point addresses.
> -sed -e 's/^\.//' |
> +sed -e 's/^\.//g' |
>  sort -u |
>  # Ignore __this_module. It's not an exported symbol, and will be resolved
>  # when the final .ko's are linked.


-- 
~Randy