From: "KaiLong Wang" <wangkailong@jari.cn>
To: mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu, farosas@linux.ibm.com,
mirq-linux@rere.qmqm.pl, dmitry.osipenko@collabora.com,
kda@linux-powerpc.org, naveen.n.rao@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH] powerpc: replace ternary operator with min()
Date: Sun, 23 Oct 2022 20:44:20 +0800 (GMT+08:00) [thread overview]
Message-ID: <4ebda26c.346.18404df6852.Coremail.wangkailong@jari.cn> (raw)
Fix the following coccicheck warning:
arch/powerpc/xmon/xmon.c:2987: WARNING opportunity for min()
arch/powerpc/xmon/xmon.c:2583: WARNING opportunity for min()
Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
arch/powerpc/xmon/xmon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index f51c882bf902..a7751cd2cc9d 100644
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -2580,7 +2580,7 @@ static void xmon_rawdump (unsigned long adrs, long ndump)
unsigned char temp[16];
for (n = ndump; n > 0;) {
- r = n < 16? n: 16;
+ r = min(n, 16);
nr = mread(adrs, temp, r);
adrs += nr;
for (m = 0; m < r; ++m) {
@@ -2984,7 +2984,7 @@ prdump(unsigned long adrs, long ndump)
for (n = ndump; n > 0;) {
printf(REG, adrs);
putchar(' ');
- r = n < 16? n: 16;
+ r = min(n, 16);
nr = mread(adrs, temp, r);
adrs += nr;
for (m = 0; m < r; ++m) {
--
2.25.1
next reply other threads:[~2022-10-23 22:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 12:44 KaiLong Wang [this message]
2022-10-24 4:33 ` [PATCH] powerpc: replace ternary operator with min() Russell Currey
2022-11-02 9:23 ` Christophe Leroy
2022-10-26 12:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ebda26c.346.18404df6852.Coremail.wangkailong@jari.cn \
--to=wangkailong@jari.cn \
--cc=christophe.leroy@csgroup.eu \
--cc=dmitry.osipenko@collabora.com \
--cc=farosas@linux.ibm.com \
--cc=kda@linux-powerpc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).