From: Tirumala Marri <tmarri@apm.com>
To: Greg KH <greg@kroah.com>, Alexander Gordeev <lasaine@lvk.cs.msu.su>
Cc: Mark Miesfeld <mmiesfeld@apm.com>,
linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Fushen Chen <fchen@apm.com>
Subject: RE: [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer
Date: Fri, 11 Feb 2011 10:33:03 -0800 [thread overview]
Message-ID: <4f99d54a42d4f13663c88b0b081f047b@mail.gmail.com> (raw)
In-Reply-To: <20110208013025.GA3151@kroah.com>
>
> > dwc_read_reg32 is used nowhere throughout the code. One of dwc_read32
> > and
> > dwc_read_reg32 should be removed IMO. There was once only
> > dwc_read_reg32. In
> > version 5 of your patchset I believe. Why did you add another function?
> > AFAIK it is not correct to store pointers in u32 because they need 8
> > bytes
> > on 64-bit archs. So it was ok with the old dwc_read_reg32.
> > [Marri] If u32 is 8bytes isn't pointer type would be 8bytes as well.
>
> Sorry, I don't understand that. I think u32 is always 32bit = 4byte on
> all archs. Right?
Yes.
Use an unsigned long if you want to hold a pointer correctly on all
arches.
[Marri] I see your point.
next prev parent reply other threads:[~2011-02-11 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:57 [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer tmarri
2011-01-26 16:17 ` Alexander Gordeev
2011-01-26 16:35 ` [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG CoreInterface Layer David Laight
2011-01-26 17:35 ` Alexander Gordeev
2011-02-07 18:45 ` Tirumala Marri
2011-02-07 18:53 ` [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer Tirumala Marri
2011-02-08 0:19 ` Alexander Gordeev
2011-02-08 1:30 ` Greg KH
2011-02-11 18:33 ` Tirumala Marri [this message]
2011-02-14 8:53 ` [PATCH V8 03/10] USB/ppc4xx: Add Synopsys DWC OTG Core InterfaceLayer David Laight
2011-02-14 11:34 ` Alexander Gordeev
2011-02-15 1:04 ` Greg KH
2011-02-08 8:58 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f99d54a42d4f13663c88b0b081f047b@mail.gmail.com \
--to=tmarri@apm.com \
--cc=fchen@apm.com \
--cc=greg@kroah.com \
--cc=lasaine@lvk.cs.msu.su \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmiesfeld@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).