From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F3D1C433DF for ; Wed, 13 May 2020 22:10:12 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF76E205ED for ; Wed, 13 May 2020 22:10:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF76E205ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stevens-zone.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49Mpkn1VzjzDqkb for ; Thu, 14 May 2020 08:10:09 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=stevens-zone.net (client-ip=212.227.126.130; helo=mout.kundenserver.de; envelope-from=darren@stevens-zone.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=stevens-zone.net Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49Mphn6CvTzDqZn for ; Thu, 14 May 2020 08:08:23 +1000 (AEST) Received: from A1K-Ubuntu.lan ([80.189.87.217]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.163]) with ESMTPA (Nemesis) id 1MhDIw-1iw61v2Axm-00ePr7; Thu, 14 May 2020 00:08:13 +0200 From: Darren Stevens To: Scott Wood Date: Wed, 13 May 2020 23:02:02 +0100 (BST) Message-ID: <4fb03d6874.55cfc4a1@auth.smtp.1and1.co.uk> In-Reply-To: References: <20200507223025.0164b95b@Cyrus.lan> User-Agent: YAM/2.9p1 (AmigaOS4; PPC; rv:20140418r7798) Subject: Re: powerpc/mpc85xx: Add Cyrus P5040 device tree source MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Jb65O9qSOs0ASSZfmqv9PwJ5+u7OfUzA6B57tNmbTANzCs9w0td +sNlM280t3Ih1v8+AcQAZst95swVIhhUkcbbGk6+hKZABvHiVGLrcGVHM/HG8PCpNUxubfx W79pZ319GdXFfqfOXoWnMlK2W8oUe6Z6cvY/62c9oORmu5T5Cvg0CX+GE405Ab006fcP8NF tW3wJyVhiLSE1nobKZsEQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:epC6Jbm9YDk=:sdyyOrcJH017LRDTAK6s3m f7qDAsa2uLRk99atidfbLRVBFPi5sO35KX3mKDPnNVl6iqlCnN32NbWSzFpAotWCyHnDVfnzt RmDt97G2xaUQdL9x+PaHU2qvB/yS8Wvuuu9R1DFqw+l8NAk4U2Mt15y0NskWHeMNHB85MyApm P2VeM93bxWSwYqhVIxGUMKQNiPQo06pZCLOjEmhyL9wvEliQcCl/B9zuUs8zL4jgycCjdtYJi aryOCnk4v3Ef8e23LHv6Cy23gWPh0z2Xpn2mtCKczCENVJPXaU1O0w9dvFJWXi5A0uP+S/m5D nhdfOJpfKHIwUJbKRoJ40DUCkGs5n2gTlF5ioPCvd+gXc/vebumBefsJqtfpwUCGWDZEkLqhC l+ERvKvQdVTe0Eb8/TmMlgXs22ruOrM1cJHHCJ2OOwKVAgltu88Os+p59ycINpDJGVEhJ9RLj YgcaMRNkA77maB7P4P0R6ILbpgu40UHxPAKDpC7CRsLtmRV9MYoVABy62ctHiTHjbso2z4xwo CsmGzv0Yld8z5cKXPEf4o9IN+yfKtGFcPiyzIYWLrgRKVEhNDVMhB6d0koiCt3Z4vm8g9+oMR 4MlXRkTb8ggUcu3u0uNiyXkJpkkAAPVBDD12qsPvXnGbjCp3kAlNoDpO3LBjlIbll/lsWLHiI x06hnV928kFvVPbWP2QYYeObMpUZyW6N1KaBjGWDfQyjVezqHVj+ZKjhWrufzPUa6MprAKaDt jhGvKzTBFKA2rmsOhnJSY3Uh4aNs2GATRPwE0H+sa+d+AAnr5Z7zDwDxBNylekwrO2rmWoT1U QnLAylA8AjRc/RaxZL4OWvDZAvOxJHD6yMQaqSic/+F8NTJDMgKlBl/KWEg7JgNBWeSht5R X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linuxppc-dev@lists.ozlabs.org, chzigotzky@xenosoft.de Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hello Scott On 08/05/2020, Scott Wood wrote: > On Thu, 2020-05-07 at 22:30 +0100, Darren Stevens wrote: >> >> +/include/ "p5040si-pre.dtsi" >> + >> +/ { >> + model = "varisys,CYRUS5040"; >> + compatible = "varisys,CYRUS"; > > Is this board 100% compatible with the Cyrus P5020 board, down to every last > quirk, except for the SoC plugged into it? If not, they shouldn't have the > same compatible. If they are, then couldn't everything in this file but the > SoC include be moved to a dtsi shared with cyrus_p5020.dts? It's not 100% compatible, the mdio ports map to different fman ports, but both as are 'corenet generic' boards, I added varisys,CYRUS so it would be detected in corenet_generic.c - support for the 5020 was added by Andy Flemming, I've just tried to copy what he did. I can add another entry to the table, but do we realy want a separate entry in the table for every supported board rather than using the device tree for similar boards? It would be nice to get these sorted, the dts files are the last bits to make these fully supported in Linux. >> + aliases{ >> + ethernet0 = &enet4; >> + ethernet1 = &enet10; >> + }; > > Space after "aliases" Opps, will be fixed on next version Thanks Darren