From: Eugene Surovegin <ebs@ebshome.net>
To: Brian Kuschak <bkuschak@yahoo.com>
Cc: linuxppc-embedded@lists.linuxppc.org
Subject: Re: virt_to_phys() on 440
Date: Mon, 08 Sep 2003 15:08:12 -0700 [thread overview]
Message-ID: <5.1.0.14.2.20030908150153.039d7288@mail.ebshome.net> (raw)
In-Reply-To: <20030908213638.4000.qmail@web40910.mail.yahoo.com>
At 02:36 PM 9/8/2003, Brian Kuschak wrote:
>I think the virt_to_phys() function is incorrect for
>PPC440. It should call iopa for all 4xx, not only the
>405. By chance, it happens to work currently if the
>address is in SDRAM, but is always incorrect for
>ioremapped addresses. virt_to_bus() does the right
>thing.
No, it shouldn't call iopa even for 405. Look at 2.6 version for example.
virt_to_phys is used only for directly mapped addresses not for ioremaped
peripherals or vmalloc space.
>Also, to be correct, shouldn't this function return a
>phys_addr_t rather than an unsigned long, as the
>physical address is >32 bits on 44x?
440 cannot handle more than 2G of RAM, so physaddr_t is not needed.
Eugene.
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-09-08 22:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-08 21:36 virt_to_phys() on 440 Brian Kuschak
2003-09-08 22:03 ` Dan Malek
2003-09-08 22:08 ` Eugene Surovegin [this message]
2003-09-08 22:14 ` Matt Porter
2003-09-08 22:36 ` Brian Kuschak
2003-09-08 23:26 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.1.0.14.2.20030908150153.039d7288@mail.ebshome.net \
--to=ebs@ebshome.net \
--cc=bkuschak@yahoo.com \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).