From: Eugene Surovegin <ebs@ebshome.net>
To: linuxppc-embedded@lists.linuxppc.org
Subject: [PATCH] ibm_emac: don't enable tx processing until device is opened
Date: Thu, 18 Sep 2003 03:01:06 -0700 [thread overview]
Message-ID: <5.1.0.14.2.20030918025210.00b09160@mail.ebshome.net> (raw)
Hi all!
There is a bug in PPC 4xx EMAC driver which in my case caused oops during
kernel startup.
Reason is simple, link timer enables tx processing _before_ device is
opened and driver may try to queue packet _before_ TCP/IP subsystem has
been initialized.
Quick fix against linuxppc-2.4 tree:
===== drivers/net/ibm_emac/ibm_ocp_enet.c 1.1 vs edited =====
--- 1.1/drivers/net/ibm_emac/ibm_ocp_enet.c Thu Jul 10 12:50:02 2003
+++ edited/drivers/net/ibm_emac/ibm_ocp_enet.c Thu Sep 18 02:51:18 2003
@@ -989,7 +989,8 @@
* latency peaks caused by this code
*/
emac_reset_configure(fep);
- emac_kick(fep);
+ if (fep->opened)
+ emac_kick(fep);
} else {
fep->timer_ticks = 0;
netif_carrier_off(fep->ndev);
Thanks,
Eugene
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
reply other threads:[~2003-09-18 10:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.1.0.14.2.20030918025210.00b09160@mail.ebshome.net \
--to=ebs@ebshome.net \
--cc=linuxppc-embedded@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).