* [PATCH] ibm_emac: don't enable tx processing until device is opened
@ 2003-09-18 10:01 Eugene Surovegin
0 siblings, 0 replies; only message in thread
From: Eugene Surovegin @ 2003-09-18 10:01 UTC (permalink / raw)
To: linuxppc-embedded
Hi all!
There is a bug in PPC 4xx EMAC driver which in my case caused oops during
kernel startup.
Reason is simple, link timer enables tx processing _before_ device is
opened and driver may try to queue packet _before_ TCP/IP subsystem has
been initialized.
Quick fix against linuxppc-2.4 tree:
===== drivers/net/ibm_emac/ibm_ocp_enet.c 1.1 vs edited =====
--- 1.1/drivers/net/ibm_emac/ibm_ocp_enet.c Thu Jul 10 12:50:02 2003
+++ edited/drivers/net/ibm_emac/ibm_ocp_enet.c Thu Sep 18 02:51:18 2003
@@ -989,7 +989,8 @@
* latency peaks caused by this code
*/
emac_reset_configure(fep);
- emac_kick(fep);
+ if (fep->opened)
+ emac_kick(fep);
} else {
fep->timer_ticks = 0;
netif_carrier_off(fep->ndev);
Thanks,
Eugene
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-09-18 10:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-09-18 10:01 [PATCH] ibm_emac: don't enable tx processing until device is opened Eugene Surovegin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).