From mboxrd@z Thu Jan 1 00:00:00 1970 Message-Id: <5.1.1.2.2.20020607222718.04331998@mail.lauterbach.com> Date: Fri, 07 Jun 2002 22:36:46 +0200 To: Tom Rini From: Franz Sirl Subject: Re: can/should we use gcc 3.1 to compile kernels Cc: "Kevin B. Hendricks" , linuxppc-dev@lists.linuxppc.org In-Reply-To: <20020607201906.GP14252@opus.bloom.county> References: <200206071544.56448.kevin.hendricks@sympatico.ca> <200206081337.31359.kevin.hendricks@sympatico.ca> <20020607193833.GO14252@opus.bloom.county> <200206071544.56448.kevin.hendricks@sympatico.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Sender: owner-linuxppc-dev@lists.linuxppc.org List-Id: At 22:19 07.06.2002, Tom Rini wrote: >On Fri, Jun 07, 2002 at 03:44:56PM -0400, Kevin B. Hendricks wrote: > > > Not too bad warnings-wize excpet for the controlfb.c where it constanly > > gave a funny warning about "pasting ->". > >Sounds right. I think there was a few other things too.. The warning is correct, pasting "token1" (CNTRL_REG) with "token2" (->) makes no sense, usually it's just a ## to much somewhere. > > It did this for every occurence of the macro CNTRL_REG which I must admit > > has two ## which I think gcc was misinterpreting somehow. > >Well, isn't: >#define x(foo) a_## foo ##_b >A semi-common thing, like we do in indirect_pci.c ? Or was it something >different? Think about preprocessing tokens! If foo is "->" the ## make no sense at all, cause "a_", "->" and "_b" are 3 separate preprocessing tokens, no need to paste them together. > > Other than that just the occaissioanal wanring about unused variables and > > things like that. > >Lots of the USB stuff uses __FUNCTION__ which gcc-3.1 isn't happy >about. It's not __FUNCTION__ per se that gcc is unhappy about, but string concatenation with it. So instead of printk ( __FUNCTION__ "text %d", value) use printk (" %s, text %d", __FUNCTION__, value). No big deal. I think current 3.2 already refuses to compile that. Franz. ** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/