From: Tabi Timur-B04825 <B04825@freescale.com>
To: Liu Qiang-B32616 <B32616@freescale.com>
Cc: Li Yang-R58472 <r58472@freescale.com>,
Vinod Koul <vinod.koul@intel.com>,
"herbert@gondor.hengli.com.au" <herbert@gondor.hengli.com.au>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [linuxppc-release] [PATCH v3 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave
Date: Mon, 16 Jul 2012 14:25:18 +0000 [thread overview]
Message-ID: <5004244D.4000106@freescale.com> (raw)
In-Reply-To: <1342411780-29930-1-git-send-email-qiang.liu@freescale.com>
Qiang Liu wrote:
> Use spin_lock_bh to instead of spin_lock_irqsave for improving performanc=
e.
You forgot to include the evidence that performance has improved, as well=20
as an explanation why it's okay to use spin_lock_bh, and why it's faster.=20
I told you to respin the patch with that information in the patch=20
description.
--=20
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-07-16 14:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 4:09 [PATCH v3 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave Qiang Liu
2012-07-16 14:25 ` Tabi Timur-B04825 [this message]
2012-07-17 4:23 ` [linuxppc-release] " Liu Qiang-B32616
2012-07-17 6:48 ` Li Yang
2012-07-17 15:29 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5004244D.4000106@freescale.com \
--to=b04825@freescale.com \
--cc=B32616@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).