From: Timur Tabi <b04825@freescale.com>
To: Liu Qiang-B32616 <B32616@freescale.com>
Cc: Li Yang-R58472 <r58472@freescale.com>,
Vinod Koul <vinod.koul@intel.com>,
"herbert@gondor.hengli.com.au" <herbert@gondor.hengli.com.au>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [linuxppc-release] [PATCH v3 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave
Date: Tue, 17 Jul 2012 10:29:11 -0500 [thread overview]
Message-ID: <500584C7.8080501@freescale.com> (raw)
In-Reply-To: <BCB48C05FCE8BC4D9E61E841ECBE6DB70C2788@039-SN2MPN1-011.039d.mgd.msft.net>
Liu Qiang-B32616 wrote:
> I attached the test result in v3 0/4, performance is improved by 2%.
> For my understanding, there is not any place to access descriptor lists
> in fsl-dma interrupt service handler except its tasklet, spin_lock_bh()
> is born for this. Interrupts will be turned off and context will be save in
> irqsave, there is needless to use irqsave in our case. You can refer to the
> implement of mv_xor.c or ioap-adma.c.
> If you think my explanation is ok, I can add it in the patch.
Yes, the explanation is ok. Please make it part of the patch description,
so that it is saved in the git history.
--
Timur Tabi
Linux kernel developer at Freescale
prev parent reply other threads:[~2012-07-17 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 4:09 [PATCH v3 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave Qiang Liu
2012-07-16 14:25 ` [linuxppc-release] " Tabi Timur-B04825
2012-07-17 4:23 ` Liu Qiang-B32616
2012-07-17 6:48 ` Li Yang
2012-07-17 15:29 ` Timur Tabi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500584C7.8080501@freescale.com \
--to=b04825@freescale.com \
--cc=B32616@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).