From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fgwmail6.fujitsu.co.jp (fgwmail6.fujitsu.co.jp [192.51.44.36]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 674B62C00C3 for ; Fri, 20 Jul 2012 17:47:03 +1000 (EST) Received: from m2.gw.fujitsu.co.jp (unknown [10.0.50.72]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 109153EE0C3 for ; Fri, 20 Jul 2012 16:47:01 +0900 (JST) Received: from smail (m2 [127.0.0.1]) by outgoing.m2.gw.fujitsu.co.jp (Postfix) with ESMTP id ECA9B45DD78 for ; Fri, 20 Jul 2012 16:47:00 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (s2.gw.fujitsu.co.jp [10.0.50.92]) by m2.gw.fujitsu.co.jp (Postfix) with ESMTP id D321945DE54 for ; Fri, 20 Jul 2012 16:47:00 +0900 (JST) Received: from s2.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id C69C1E18004 for ; Fri, 20 Jul 2012 16:47:00 +0900 (JST) Received: from g01jpexchyt03.g01.fujitsu.local (g01jpexchyt03.g01.fujitsu.local [10.128.194.42]) by s2.gw.fujitsu.co.jp (Postfix) with ESMTP id 5560F1DB803E for ; Fri, 20 Jul 2012 16:47:00 +0900 (JST) Message-ID: <50090CE0.3040409@jp.fujitsu.com> Date: Fri, 20 Jul 2012 16:46:40 +0900 From: Yasuaki Ishimatsu MIME-Version: 1.0 To: Wen Congyang Subject: Re: [RFC PATCH 2/8] memory-hotplug: offline memory only when it is onlined References: <5009038A.4090001@cn.fujitsu.com> <5009044B.7050203@cn.fujitsu.com> In-Reply-To: <5009044B.7050203@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Cc: len.brown@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, paulus@samba.org, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, cl@linux.com, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org, liuj97@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Wen, 2012/07/20 16:10, Wen Congyang wrote: > offline_memory() will fail if the memory is not onlined. So check > whether the memory is onlined before calling offline_memory(). > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > CC: Yasuaki Ishimatsu > Signed-off-by: Wen Congyang > --- I have no comment. Reviewed-by: Yasuaki Ishimatsu Thanks, Yasuaki Ishimatsu > drivers/acpi/acpi_memhotplug.c | 10 +++++++--- > 1 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c > index db8de39..712e767 100644 > --- a/drivers/acpi/acpi_memhotplug.c > +++ b/drivers/acpi/acpi_memhotplug.c > @@ -323,9 +323,13 @@ static int acpi_memory_disable_device(struct acpi_memory_device *mem_device) > */ > list_for_each_entry_safe(info, n, &mem_device->res_list, list) { > if (info->enabled) { > - result = offline_memory(info->start_addr, info->length); > - if (result) > - return result; > + if (!is_memblk_offline(info->start_addr, > + info->length)) { > + result = offline_memory(info->start_addr, > + info->length); > + if (result) > + return result; > + } > } > list_del(&info->list); > kfree(info); >