From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe002.messaging.microsoft.com [216.32.180.12]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 022DF2C007F for ; Sat, 28 Jul 2012 02:37:33 +1000 (EST) Message-ID: <5012C3C2.7060205@freescale.com> Date: Fri, 27 Jul 2012 11:37:22 -0500 From: Scott Wood MIME-Version: 1.0 To: Jia Hongtao-B38951 Subject: Re: [PATCH 3/6] powerpc/fsl-pci: Determine primary bus by looking for ISA node References: <1343125210-16720-1-git-send-email-B38951@freescale.com> <1343125210-16720-3-git-send-email-B38951@freescale.com> <500EEDD9.8050507@freescale.com> <412C8208B4A0464FA894C5F0C278CD5D01A275B4@039-SN1MPN1-002.039d.mgd.msft.net> <50102C27.8040004@freescale.com> <412C8208B4A0464FA894C5F0C278CD5D01A27C7D@039-SN1MPN1-002.039d.mgd.msft.net> <5011F01C.8000008@freescale.com> <412C8208B4A0464FA894C5F0C278CD5D01A285D0@039-SN1MPN1-002.039d.mgd.msft.net> In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01A285D0@039-SN1MPN1-002.039d.mgd.msft.net> Content-Type: text/plain; charset="UTF-8" Cc: Wood Scott-B07421 , "linuxppc-dev@lists.ozlabs.org" , Li Yang-R58472 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/26/2012 09:07 PM, Jia Hongtao-B38951 wrote: > > >> -----Original Message----- >> From: Wood Scott-B07421 >> Sent: Friday, July 27, 2012 9:34 AM >> To: Jia Hongtao-B38951 >> Cc: Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org; >> galak@kernel.crashing.org; Li Yang-R58472 >> Subject: Re: [PATCH 3/6] powerpc/fsl-pci: Determine primary bus by >> looking for ISA node >> >> On 07/25/2012 09:20 PM, Jia Hongtao-B38951 wrote: >>> All this recursion thing I will try another way. >>> >>> But this is not the same as you did. If we use platform driver probe >> function >>> will be called more than once. Your function is to find ISA node and >> check if >>> the parent equal to this PCI controller. My function is to search ISA >> under >>> each PCI controller. >> >> The result is the same -- "does this PCI controller have an ISA node >> under it?" >> >> -Scott > > > The result is the same but as I said in platform driver probe function will > be called for each PCI controller. So? Just because you've got a platform device now doesn't mean you can't do any early global init. This has to be done globally, so we can choose a fallback primary bus if there's no ISA in the system. -Scott