From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va3outboundpool.messaging.microsoft.com (va3ehsobe010.messaging.microsoft.com [216.32.180.30]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client CN "mail.global.frontbridge.com", Issuer "Microsoft Secure Server Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 40DE82C0040 for ; Sat, 28 Jul 2012 06:24:41 +1000 (EST) Message-ID: <5012F8FD.8030905@freescale.com> Date: Fri, 27 Jul 2012 15:24:29 -0500 From: Scott Wood MIME-Version: 1.0 To: Jia Hongtao-B38951 Subject: Re: [PATCH V3 1/5] powerpc/fsl-pci: Unify pci/pcie initialization code References: <1343305827-26734-1-git-send-email-B38951@freescale.com> <412C8208B4A0464FA894C5F0C278CD5D01A289D8@039-SN1MPN1-002.039d.mgd.msft.net> In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01A289D8@039-SN1MPN1-002.039d.mgd.msft.net> Content-Type: text/plain; charset="UTF-8" Cc: Wood Scott-B07421 , "linuxppc-dev@lists.ozlabs.org" , Li Yang-R58472 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 07/27/2012 05:10 AM, Jia Hongtao-B38951 wrote: > Hi kumar, > > I know "duplicate code from pci_process_bridge_OF_ranges()" is > hard to accept but "refactor the code to have a shared function" > is knotty. Actually this is the reason I didn't do the refactor. Maybe we should keep doing the init early? We could still have a platform device for the PM stuff, but some init would be done before probe. Another possibility is to try to handle swiotlb init later -- possibly by reserving memory for it if the platform indicates it's a possibility that it will be needed, then freeing the memory if it's not needed. -Scott