From: Scott Wood <scottwood@freescale.com>
To: Jia Hongtao-B38951 <B38951@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Li Yang-R58472 <r58472@freescale.com>
Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code
Date: Fri, 3 Aug 2012 11:03:56 -0500 [thread overview]
Message-ID: <501BF66C.3070107@freescale.com> (raw)
In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01A35A2F@039-SN1MPN1-002.039d.mgd.msft.net>
On 08/02/2012 10:39 PM, Jia Hongtao-B38951 wrote:
>
>
>> -----Original Message-----
>> From: Kumar Gala [mailto:galak@kernel.crashing.org]
>> Sent: Thursday, August 02, 2012 8:24 PM
>> To: Jia Hongtao-B38951
>> Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472
>> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie
>> initialization code
>>
>> You need to convert all boards to use fsl_pci_init before this patch.
>> Otherwise we'll end up with PCI getting initialized twice on boards.
>>
>> - k
>
> If we covert all boards with platform driver in this patch PCI will
> be initialized only once without converting all boards to use
> fsl_pci_init first.
Then we'd have to pick apart core changes from board changes when reviewing.
> If we convert all boards to use fsl_pci_init before this patch and
> convert them to use platform driver again after this patch. Then
> between this patch and next pci will be initialized twice too.
Why? That one patch should both create the platform driver and remove
the init from fsl_pci_init() -- except things like primary bus detection
which has to happen globally.
-Scott
next prev parent reply other threads:[~2012-08-03 16:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 11:42 [PATCH V4 0/3] PCI patch set description Jia Hongtao
2012-08-02 11:42 ` [PATCH V4 1/3] powerpc/fsl-pci: Only scan PCI bus if configured as a host Jia Hongtao
2012-08-02 11:42 ` [PATCH V4 2/3] powerpc/swiotlb: Enable at early stage and disable if not necessary Jia Hongtao
2012-08-02 12:54 ` Kumar Gala
2012-08-03 2:21 ` Jia Hongtao-B38951
2012-08-03 12:38 ` Kumar Gala
2012-08-03 14:42 ` Li Yang
2012-08-03 16:15 ` Kumar Gala
2012-08-02 11:42 ` [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code Jia Hongtao
2012-08-02 12:23 ` Kumar Gala
2012-08-02 15:59 ` Scott Wood
2012-08-03 3:39 ` Jia Hongtao-B38951
2012-08-03 16:03 ` Scott Wood [this message]
2012-08-06 2:39 ` Jia Hongtao-B38951
2012-08-06 15:15 ` Scott Wood
2012-08-07 6:23 ` Jia Hongtao-B38951
2012-08-07 15:19 ` Scott Wood
2012-08-08 3:57 ` Jia Hongtao-B38951
2012-08-08 15:53 ` Scott Wood
2012-08-09 3:52 ` Jia Hongtao-B38951
2012-08-10 22:59 ` Scott Wood
2012-08-02 20:18 ` Scott Wood
2012-08-03 2:20 ` Jia Hongtao-B38951
2012-08-03 16:09 ` Scott Wood
2012-08-06 4:11 ` Tabi Timur-B04825
2012-08-06 14:03 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501BF66C.3070107@freescale.com \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B38951@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).