From: Scott Wood <scottwood@freescale.com>
To: Jia Hongtao-B38951 <B38951@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Li Yang-R58472 <r58472@freescale.com>
Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code
Date: Fri, 3 Aug 2012 11:09:32 -0500 [thread overview]
Message-ID: <501BF7BC.1030208@freescale.com> (raw)
In-Reply-To: <412C8208B4A0464FA894C5F0C278CD5D01A359AF@039-SN1MPN1-002.039d.mgd.msft.net>
On 08/02/2012 09:20 PM, Jia Hongtao-B38951 wrote:
>
>
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Friday, August 03, 2012 4:19 AM
>> To: Jia Hongtao-B38951
>> Cc: linuxppc-dev@lists.ozlabs.org; galak@kernel.crashing.org; Wood Scott-
>> B07421; Li Yang-R58472
>> Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie
>> initialization code
>>
>> Why are you eliminating the uli lookup? We don't want to call
>> uli_exclude_device on boards that don't have a uli.
>>
>> -Scott
>
> I found out that all 85xx_ds boards (mpc8572ds, mpc8544ds, p2020ds) have
> ULI.
Perhaps all boards currently handled by this file do, but it's not true
for all mpc85xx_ds boards. I think we could handle mpc8536ds here if we
didn't hardcode the uli assumption. Not critical, but would be nice to
make this more device tree driven.
p1022ds OTOH is weird enough that it deserves its own board file.
> Also in platform driver fsl_pci_primary is determined at arch_initcall
> which means at the stage of board_setup_arch fsl_pci_primary is not ready.
You could export the primary detection function so that boards can call
it early if they want.
-Scott
next prev parent reply other threads:[~2012-08-03 16:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-02 11:42 [PATCH V4 0/3] PCI patch set description Jia Hongtao
2012-08-02 11:42 ` [PATCH V4 1/3] powerpc/fsl-pci: Only scan PCI bus if configured as a host Jia Hongtao
2012-08-02 11:42 ` [PATCH V4 2/3] powerpc/swiotlb: Enable at early stage and disable if not necessary Jia Hongtao
2012-08-02 12:54 ` Kumar Gala
2012-08-03 2:21 ` Jia Hongtao-B38951
2012-08-03 12:38 ` Kumar Gala
2012-08-03 14:42 ` Li Yang
2012-08-03 16:15 ` Kumar Gala
2012-08-02 11:42 ` [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code Jia Hongtao
2012-08-02 12:23 ` Kumar Gala
2012-08-02 15:59 ` Scott Wood
2012-08-03 3:39 ` Jia Hongtao-B38951
2012-08-03 16:03 ` Scott Wood
2012-08-06 2:39 ` Jia Hongtao-B38951
2012-08-06 15:15 ` Scott Wood
2012-08-07 6:23 ` Jia Hongtao-B38951
2012-08-07 15:19 ` Scott Wood
2012-08-08 3:57 ` Jia Hongtao-B38951
2012-08-08 15:53 ` Scott Wood
2012-08-09 3:52 ` Jia Hongtao-B38951
2012-08-10 22:59 ` Scott Wood
2012-08-02 20:18 ` Scott Wood
2012-08-03 2:20 ` Jia Hongtao-B38951
2012-08-03 16:09 ` Scott Wood [this message]
2012-08-06 4:11 ` Tabi Timur-B04825
2012-08-06 14:03 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=501BF7BC.1030208@freescale.com \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B38951@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).