From: Scott Wood <scottwood@freescale.com>
To: Wang Dongsheng-B40534 <B40534@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
Li Yang-R58472 <r58472@freescale.com>,
"paulus@samba.org" <paulus@samba.org>,
Gala Kumar-B11780 <B11780@freescale.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
Date: Mon, 13 Aug 2012 11:49:19 -0500 [thread overview]
Message-ID: <5029300F.60600@freescale.com> (raw)
In-Reply-To: <ABB05CD9C9F68C46A5CEDC7F15439259DB147E@039-SN2MPN1-022.039d.mgd.msft.net>
On 08/13/2012 12:53 AM, Wang Dongsheng-B40534 wrote:
>
>
>> -----Original Message-----
>> From: Wood Scott-B07421
>> Sent: Saturday, August 11, 2012 3:40 AM
>> To: Wang Dongsheng-B40534
>> Cc: benh@kernel.crashing.org; paulus@samba.org; linuxppc-
>> dev@lists.ozlabs.org; Gala Kumar-B11780; Li Yang-R58472
>> Subject: Re: [PATCH v2 2/2] powerpc/mpic: add global timer support
>>
>> On 08/10/2012 12:54 AM, Dongsheng.wang@freescale.com wrote:
>>> +static const struct of_device_id mpic_timer_ids[] = {
>>> + { .compatible = "open-pic,global-timer", },
>>> + { .compatible = "fsl,global-timer", },
>>> + {},
>>> +};
>>> +
>>> +static int __init mpic_timer_init(void) {
>>> + struct device_node *np = NULL;
>>> +
>>> + for_each_node_by_type(np, "open-pic")
>>> + if (of_match_node(mpic_timer_ids, np))
>>> + group_init(np);
>>> +
>>> + if (list_empty(&group_list))
>>> + return -ENODEV;
>>> +
>>> + return 0;
>>> +}
>>> +arch_initcall(mpic_timer_init);
>>
>> Oh, and don't probe by device_type.
>>
> [Wang Dongsheng] fine. for_each_node_by_name.
No. Probe by compatible only.
-Scott
next prev parent reply other threads:[~2012-08-13 16:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 5:54 [PATCH v2 2/2] powerpc/mpic: add global timer support Dongsheng.wang
2012-08-10 19:40 ` Scott Wood
2012-08-10 20:24 ` Gala Kumar-B11780
2012-08-13 5:53 ` Wang Dongsheng-B40534
2012-08-13 6:17 ` Li Yang-R58472
2012-08-13 16:50 ` Scott Wood
2012-08-13 16:49 ` Scott Wood [this message]
2012-08-14 2:06 ` Wang Dongsheng-B40534
2012-08-10 20:37 ` Scott Wood
2012-08-13 6:18 ` Wang Dongsheng-B40534
2012-08-13 17:36 ` Scott Wood
2012-08-14 2:00 ` Wang Dongsheng-B40534
2012-08-14 2:05 ` Scott Wood
2012-08-14 2:15 ` Wang Dongsheng-B40534
2012-08-14 2:18 ` Scott Wood
2012-08-14 2:32 ` Wang Dongsheng-B40534
2012-08-14 21:20 ` Scott Wood
2012-08-11 13:10 ` Tabi Timur-B04825
2012-08-13 6:20 ` Wang Dongsheng-B40534
2012-08-13 6:25 ` Wang Dongsheng-B40534
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5029300F.60600@freescale.com \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B11780@freescale.com \
--cc=B40534@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).