From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f51.google.com (mail-pz0-f51.google.com [209.85.210.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 0A8392C00A2 for ; Tue, 21 Aug 2012 00:09:53 +1000 (EST) Received: by dajt11 with SMTP id t11so2628296daj.38 for ; Mon, 20 Aug 2012 07:09:51 -0700 (PDT) Message-ID: <50324524.5000501@gmail.com> Date: Mon, 20 Aug 2012 22:09:40 +0800 From: Jianguo Wu MIME-Version: 1.0 To: wency@cn.fujitsu.com Subject: Re: [RFC V7 PATCH 18/19] memory-hotplug: add node_device_release References: <1345455342-27752-1-git-send-email-wency@cn.fujitsu.com> <1345455342-27752-19-git-send-email-wency@cn.fujitsu.com> In-Reply-To: <1345455342-27752-19-git-send-email-wency@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-acpi@vger.kernel.org, len.brown@intel.com, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, cmetcalf@tilera.com, linux-mm@kvack.org, isimatu.yasuaki@jp.fujitsu.com, paulus@samba.org, minchan.kim@gmail.com, kosaki.motohiro@jp.fujitsu.com, rientjes@google.com, cl@linux.com, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org, liuj97@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2012/8/20 17:35, wency@cn.fujitsu.com wrote: > From: Yasuaki Ishimatsu > > When calling unregister_node(), the function shows following message at > device_release(). > > Device 'node2' does not have a release() function, it is broken and must be > fixed. > > So the patch implements node_device_release() > > CC: David Rientjes > CC: Jiang Liu > CC: Len Brown > CC: Benjamin Herrenschmidt > CC: Paul Mackerras > CC: Christoph Lameter > Cc: Minchan Kim > CC: Andrew Morton > CC: KOSAKI Motohiro > Signed-off-by: Yasuaki Ishimatsu > Signed-off-by: Wen Congyang > --- > drivers/base/node.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index af1a177..9bc2f57 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -252,6 +252,13 @@ static inline void hugetlb_register_node(struct node *node) {} > static inline void hugetlb_unregister_node(struct node *node) {} > #endif > > +static void node_device_release(struct device *dev) > +{ > + struct node *node_dev = to_node(dev); > + > + flush_work(&node_dev->node_work); Hi Congyang, I think this should be: #if defined(CONFIG_MEMORY_HOTPLUG_SPARSE) && defined(CONFIG_HUGETLBFS) flush_work(&node_dev->node_work); #endif As struct node defined in node.h: struct node { struct sys_device sysdev; #if defined(CONFIG_MEMORY_HOTPLUG_SPARSE) && defined(CONFIG_HUGETLBFS) struct work_struct node_work; #endif }; Thanks Jianguo Wu > + memset(node_dev, 0, sizeof(struct node)); > +} > > /* > * register_node - Setup a sysfs device for a node. > @@ -265,6 +272,7 @@ int register_node(struct node *node, int num, struct node *parent) > > node->dev.id = num; > node->dev.bus = &node_subsys; > + node->dev.release = node_device_release; > error = device_register(&node->dev); > > if (!error){ >