From: Scott Wood <scottwood@freescale.com>
To: Li Yang-R58472 <r58472@freescale.com>
Cc: Wood Scott-B07421 <B07421@freescale.com>,
Bradley Hughes <bhughes@silicontkx.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Jia Hongtao-B38951 <B38951@freescale.com>
Subject: Re: [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code
Date: Tue, 21 Aug 2012 12:16:00 -0500 [thread overview]
Message-ID: <5033C250.2000904@freescale.com> (raw)
In-Reply-To: <94F013E7935FF44C83EBE7784D62AD3F093BD870@039-SN2MPN1-023.039d.mgd.msft.net>
On 08/21/2012 01:49 AM, Li Yang-R58472 wrote:
> If there is i8259 node in the device tree, it should be suggesting
> that there is a PCI to ISA bridge but not explicitly described in the
> device tree. Then we need to fix the device tree to add the ISA
> nodes.
No, we need to work with existing device trees. Just because they're
hosted in the kernel tree doesn't mean they can be treated as an
internal kernel implementation detail. They are stable API with
external entities such as bootloaders and hypervisors, get forked for
custom boards, etc.
Boards with this problem should set fsl_pci_primary in platform code
based on whatever criteria is relevant.
-Scott
next prev parent reply other threads:[~2012-08-21 17:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 10:06 [PATCH V8] powerpc/fsl-pci: Unify pci/pcie initialization code Jia Hongtao
2012-08-20 22:04 ` Scott Wood
2012-08-21 0:56 ` Scott Wood
2012-08-21 3:27 ` Jia Hongtao-B38951
2012-08-21 3:26 ` Jia Hongtao-B38951
2012-08-21 6:49 ` Li Yang-R58472
2012-08-21 17:16 ` Scott Wood [this message]
2012-08-21 18:09 ` Li Yang-R58472
2012-08-21 18:24 ` Scott Wood
2012-08-21 18:33 ` Scott Wood
2012-08-22 7:41 ` Jia Hongtao-B38951
-- strict thread matches above, loose matches on Subject: below --
2012-08-20 9:55 Jia Hongtao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5033C250.2000904@freescale.com \
--to=scottwood@freescale.com \
--cc=B07421@freescale.com \
--cc=B38951@freescale.com \
--cc=bhughes@silicontkx.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r58472@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).