From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id A0925DDE22 for ; Wed, 11 Jul 2007 20:57:19 +1000 (EST) In-Reply-To: References: <1184082728.20129.187.camel@localhost.localdomain> <963D5B48-F1E5-4930-9F29-98D7F0E33C0A@kernel.crashing.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <503D28B7-4D60-4507-9D66-BD59C0E59951@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [patch 3/6] Add 8548 CDS PCI express controller node and PCI-X device node Date: Wed, 11 Jul 2007 12:57:05 +0200 To: Kumar Gala Cc: Paul Mackerras , linuxppc-dev list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> + compatible = "fsl,mpc86xx-pciex","86xx"; >> >> And "xx" again. Aren't the 85- and 86- PCIe controllers >> compatible, btw? > > They are, but we need to distinguish between 83xx, 85xx, and 86xx > pci, pciex, pci-x controllers. Sure, but if 85xx-pcie and 86xx-pcie are compatible, the OS driver can match on the same "compatible" entry for both. Just choose one -- "fsl,8641-pcie" or something. It is a good idea to put the exact name of the controller on the board in the first "compatible" entry in case it is found later that some specific model needs a workaround or some other special treatment, but in general, everything can just use the generic "grandfather" model to match on. Segher