From: Scott Wood <scottwood@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH 2/2] powerpc/e6500: TLB miss handler with hardware tablewalk support
Date: Mon, 10 Sep 2012 19:26:34 -0500 [thread overview]
Message-ID: <504E853A.1010305@freescale.com> (raw)
In-Reply-To: <1347061804.2385.58.camel@pasglop>
On 09/07/2012 06:50 PM, Benjamin Herrenschmidt wrote:
>>>>> #endif /* CONFIG_PPC64 */
>>>>> @@ -377,7 +382,7 @@ void tlb_flush_pgtable(struct mmu_gather *tlb, unsigned long address)
>>>>> {
>>>>> int tsize = mmu_psize_defs[mmu_pte_psize].enc;
>>>>>
>>>>> - if (book3e_htw_enabled) {
>>>>> + if (book3e_htw_mode) {
>>>>
>>>> Make it if (boot3e_htw_enabled != PPC_HTW_NONE)
>>
>> Seems a little verbose, but OK.
>>
>> Same with things like this, I guess:
>> book3e_htw_mode ? "enabled" : "not supported"
>
> Well, it's no longer a boolean so ...
It's pretty common to use implicit boolean conversion when a zero value
means no/false/absent, even if there are multiple non-false
possibilities (e.g. pointers) -- but not a big deal to change it if you
prefer.
> BTW. On another note, can you pickup Ananth series for larger address
> space (minus the one patch that breaks the BookE build, it shouldn't
> matter) and see if there's any runtime issue on BookE 64 ? (And whether
> the larger address space actually works for you too, using something
> like high up mmap tests)
It booted OK for me in my initial testing with a ramdisk, but when I
tried to use the network (to load a high mmap test program) I got hangs
that didn't happen before that patchset. I'll look into it more tomorrow.
-Scott
next prev parent reply other threads:[~2012-09-11 0:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 23:41 [PATCH 2/2] powerpc/e6500: TLB miss handler with hardware tablewalk support Scott Wood
2012-06-15 1:05 ` Benjamin Herrenschmidt
2012-06-15 16:50 ` Scott Wood
2012-06-15 22:02 ` Benjamin Herrenschmidt
2012-07-19 20:12 ` Scott Wood
2012-09-08 23:09 ` Benjamin Herrenschmidt
2012-09-07 4:41 ` Benjamin Herrenschmidt
[not found] ` <504A4C3D.3040709@freescale.com>
2012-09-07 23:01 ` Scott Wood
2012-09-07 23:50 ` Benjamin Herrenschmidt
2012-09-08 0:55 ` Nishanth Aravamudan
2012-09-08 10:15 ` Benjamin Herrenschmidt
2012-09-11 0:26 ` Scott Wood [this message]
2012-09-11 17:06 ` Caraman Mihai Claudiu-B02008
2012-09-11 17:24 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504E853A.1010305@freescale.com \
--to=scottwood@freescale.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).