From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <505107DF.5020105@gmail.com> Date: Wed, 12 Sep 2012 17:08:31 -0500 From: Rob Herring MIME-Version: 1.0 To: Sebastian Andrzej Siewior Subject: Re: [PATCH] of: specify initrd location using 64-bit References: <1347465937-7056-1-git-send-email-cyril@ti.com> <5050CE33.9060909@ti.com> <5050E965.5080405@linutronix.de> In-Reply-To: <5050E965.5080405@linutronix.de> Content-Type: text/plain; charset=ISO-8859-1 Cc: linux-mips@linux-mips.org, a-jacquiot@ti.com, mahesh@linux.vnet.ibm.com, linux@openrisc.net, paul.gortmaker@windriver.com, paulus@samba.org, hpa@zytor.com, m.szyprowski@samsung.com, jonas@southpole.se, linux@arm.linux.org.uk, linux-c6x-dev@linux-c6x.org, nico@linaro.org, x86@kernel.org, mingo@redhat.com, suzuki@in.ibm.com, Cyril Chemparathy , Geert Uytterhoeven , linus.walleij@linaro.org, arnd@arndb.de, microblaze-uclinux@itee.uq.edu.au, devicetree-discuss@lists.ozlabs.org, msalter@redhat.com, rob.herring@calxeda.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, blogic@openwrt.org, dhowells@redhat.com, monstr@monstr.eu, david.daney@cavium.com, linux-kernel@vger.kernel.org, ralf@linux-mips.org, tj@kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 09/12/2012 02:58 PM, Sebastian Andrzej Siewior wrote: > On 09/12/2012 08:02 PM, Cyril Chemparathy wrote: >>>> -void __init early_init_dt_setup_initrd_arch(unsigned long start, >>>> unsigned long end) >>>> +void __init early_init_dt_setup_initrd_arch(u64 start, u64 end) >>> >>> Why not phys_addr_t? >>> >> >> The rest of the memory specific bits of the device-tree code use u64 for >> addresses, and I kept it the same for consistency. > > Geert is right here. If it is a physical address, it should be > phys_addr_t. While generally true, for the DT specific code I think it should be a fixed u64. The size of the address is defined by the FDT, not the kernel. It is very likely we could have a FDT that specifies addresses in 64-bit values, but then we boot a kernel is compiled for !LPAE. phys_addr_t is currently sized based on LPAE setting. Also, this is how the memory and reserved nodes are handled currently, so we should be consistent. Rob