* [PATCH v2 4/7] dt/powerpc/sysdev: Use of_get_child_by_name to get a named child.
@ 2012-09-14 8:19 Srinivas KANDAGATLA
2012-09-14 13:05 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-09-14 8:19 UTC (permalink / raw)
To: benh; +Cc: robherring2, devicetree-discuss, linuxppc-dev,
srinivas.kandagatla
From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
As follow-up to "dt: introduce of_get_child_by_name to get child node by
name." patch, This patch removes some of the code duplication in the
driver by replacing it with of_get_child_by_name instead.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
---
arch/powerpc/sysdev/qe_lib/qe.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
index b043675..fd1c15d 100644
--- a/arch/powerpc/sysdev/qe_lib/qe.c
+++ b/arch/powerpc/sysdev/qe_lib/qe.c
@@ -568,10 +568,7 @@ struct qe_firmware_info *qe_get_firmware_info(void)
}
/* Find the 'firmware' child node */
- for_each_child_of_node(qe, fw) {
- if (strcmp(fw->name, "firmware") == 0)
- break;
- }
+ fw = of_get_child_by_name(qe "firmware");
of_node_put(qe);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 4/7] dt/powerpc/sysdev: Use of_get_child_by_name to get a named child.
2012-09-14 8:19 [PATCH v2 4/7] dt/powerpc/sysdev: Use of_get_child_by_name to get a named child Srinivas KANDAGATLA
@ 2012-09-14 13:05 ` Rob Herring
2012-09-14 13:15 ` Srinivas KANDAGATLA
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2012-09-14 13:05 UTC (permalink / raw)
To: Srinivas KANDAGATLA; +Cc: devicetree-discuss, linuxppc-dev
On 09/14/2012 03:19 AM, Srinivas KANDAGATLA wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>
> As follow-up to "dt: introduce of_get_child_by_name to get child node by
> name." patch, This patch removes some of the code duplication in the
> driver by replacing it with of_get_child_by_name instead.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
> ---
> arch/powerpc/sysdev/qe_lib/qe.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
> index b043675..fd1c15d 100644
> --- a/arch/powerpc/sysdev/qe_lib/qe.c
> +++ b/arch/powerpc/sysdev/qe_lib/qe.c
> @@ -568,10 +568,7 @@ struct qe_firmware_info *qe_get_firmware_info(void)
> }
>
> /* Find the 'firmware' child node */
> - for_each_child_of_node(qe, fw) {
> - if (strcmp(fw->name, "firmware") == 0)
> - break;
> - }
> + fw = of_get_child_by_name(qe "firmware");
Missing comma.
>
> of_node_put(qe);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2 4/7] dt/powerpc/sysdev: Use of_get_child_by_name to get a named child.
2012-09-14 13:05 ` Rob Herring
@ 2012-09-14 13:15 ` Srinivas KANDAGATLA
0 siblings, 0 replies; 3+ messages in thread
From: Srinivas KANDAGATLA @ 2012-09-14 13:15 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree-discuss, linuxppc-dev
Thanks for pointing the typo..
On 14/09/12 14:05, Rob Herring wrote:
> On 09/14/2012 03:19 AM, Srinivas KANDAGATLA wrote:
>> From: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>>
>> As follow-up to "dt: introduce of_get_child_by_name to get child node by
>> name." patch, This patch removes some of the code duplication in the
>> driver by replacing it with of_get_child_by_name instead.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@st.com>
>> ---
>> arch/powerpc/sysdev/qe_lib/qe.c | 5 +----
>> 1 files changed, 1 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc/sysdev/qe_lib/qe.c
>> index b043675..fd1c15d 100644
>> --- a/arch/powerpc/sysdev/qe_lib/qe.c
>> +++ b/arch/powerpc/sysdev/qe_lib/qe.c
>> @@ -568,10 +568,7 @@ struct qe_firmware_info *qe_get_firmware_info(void)
>> }
>>
>> /* Find the 'firmware' child node */
>> - for_each_child_of_node(qe, fw) {
>> - if (strcmp(fw->name, "firmware") == 0)
>> - break;
>> - }
>> + fw = of_get_child_by_name(qe "firmware");
> Missing comma.
>
>>
>> of_node_put(qe);
>>
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-14 13:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 8:19 [PATCH v2 4/7] dt/powerpc/sysdev: Use of_get_child_by_name to get a named child Srinivas KANDAGATLA
2012-09-14 13:05 ` Rob Herring
2012-09-14 13:15 ` Srinivas KANDAGATLA
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).