linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Robert Berger <robert.karl.berger@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, rsarmah@apm.com, mla@apm.com
Subject: Re: ELDK 4.2/kilauea/3.5+ kernel broken
Date: Wed, 24 Oct 2012 08:45:45 +0300	[thread overview]
Message-ID: <50878089.6060301@gmail.com> (raw)
In-Reply-To: <1350849666.2476.138.camel__11705.9888471433$1350849778$gmane$org@pasglop>

Hi Ben,
>
> Remind me what is the symptom ? A specific device isn't working ? Or the
> whole kernel goes toast ?

The whole kernel goes toast! Just reboots without saying much before;)

> My feeling is that those patches make MSIs
> work (well that's what they are supposed to do) and for some reason that
> doesn't agree with whatever you have connected to the PCIe slot...

I have nothing connected to the PCIe slot. Just a standard kilauea eval
board with a defconfig and a 3.6 kernel, so if someone has a kilauea
board it should be very easy to reproduce.

Mai, Rupjyoti do you have a kilauea bard lying around to test?

Maybe it's the kilauea fdt?

If I hard code NR_MSI_IRQS (as it used to be) at least the kernel boots
and I can work with the board. (I don't think MSI interrupts work).

23c23
< #define DEBUG
---
>
47d46
< #define NR_MSI_IRQS	4
55c54
< 	int msi_virqs[NR_MSI_IRQS];
---
> 	int *msi_virqs;
67c66
< 	err = msi_bitmap_alloc(&msi_data->bitmap, NR_MSI_IRQS,
---
> 	err = msi_bitmap_alloc(&msi_data->bitmap, msi_irqs,
88a88,92
> 	msi_data->msi_virqs = kmalloc((msi_irqs) * sizeof(int),
> 					    GFP_KERNEL);
> 	if (!msi_data->msi_virqs)
> 		return -ENOMEM;
>
192a197,198
> 	dma_free_coherent(&dev->dev, 64, msi_virt, msi_phys);
>
202c208
< 	for (i = 0; i < NR_MSI_IRQS; i++) {
---
> 	for (i = 0; i < msi_irqs; i++) {
223,224d228
< 	/*msi = &ppc4xx_msi;*//*keep the msi data for further use*/
<

Regards,

Robert

>
> Cheers,
> Ben.
>

...If it's there, and you can see it, it's real. - If it's not there,
and you can see it, it's virtual.- If it's there, and you can't see it,
it's transparent.- If it's not there, and you can't see it, you erased
it. (from some mailing list)

My public pgp key is available,at:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x90320BF1

  parent reply	other threads:[~2012-10-24  5:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <507EF5AD.5070203__24977.4320669987$1350497770$gmane$org@gmail.com>
2012-10-18 16:27 ` ELDK 4.2/kilauea/3.5+ kernel broken Robert Berger
2012-10-18 16:33 ` Robert Berger
     [not found] ` <50802F4C.3000309__36526.1883860969$1350578085$gmane$org@gmail.com>
2012-10-18 17:45   ` Robert Berger
2012-10-18 19:03     ` Benjamin Herrenschmidt
2012-10-18 20:05       ` Robert Berger
2012-10-19  3:16         ` Mai La
2012-10-19  6:35           ` Robert Berger
     [not found]     ` <1350587006.2476.12.camel__24873.815305955$1350587085$gmane$org@pasglop>
2012-10-21 15:35       ` Robert Berger
2012-10-21 20:01         ` Benjamin Herrenschmidt
     [not found]         ` <1350849666.2476.138.camel__11705.9888471433$1350849778$gmane$org@pasglop>
2012-10-24  5:45           ` Robert Berger [this message]
2013-01-04  4:08             ` Benjamin Herrenschmidt
2012-10-21 15:39       ` Robert Berger
2012-10-17 18:15 Robert Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50878089.6060301@gmail.com \
    --to=robert.karl.berger@gmail.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mla@apm.com \
    --cc=rsarmah@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).