From: Roger Quadros <rogerq@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-doc@vger.kernel.org, tony@atomide.com,
linux@arm.linux.org.uk, linux-sh@vger.kernel.org,
alexander.shishkin@linux.intel.com, stern@rowland.harvard.edu,
devicetree-discuss@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org, rob.herring@calxeda.com,
horms@verge.net.au, haojian.zhuang@gmail.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
eric.y.miao@gmail.com, b-cousson@ti.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@ti.com, cbou@mail.ru,
rob@landley.net, dwmw2@infradead.org
Subject: Re: [RFC PATCH 3/6] usb: otg: utils: change the phy lib to support multiple PHYs of same type
Date: Thu, 17 Jan 2013 18:07:57 +0200 [thread overview]
Message-ID: <50F821DD.1040609@ti.com> (raw)
In-Reply-To: <1358348462-27693-4-git-send-email-kishon@ti.com>
On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote:
> In order to add support for multipe PHY's of the same type, the API's
> for adding PHY and getting PHY has been changed. Now the binding
> information of the PHY and controller should be done in platform file
> using usb_bind_phy API. And for getting a PHY, the device pointer of the
> USB controller and an index should be passed. Based on the binding
> information that is added in the platform file, get_phy will return the
> approappropriate PHY.
>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> arch/arm/mach-shmobile/board-marzen.c | 2 +-
> drivers/power/ab8500_charger.c | 2 +-
> drivers/power/isp1704_charger.c | 2 +-
> drivers/power/pda_power.c | 2 +-
> drivers/power/twl4030_charger.c | 2 +-
> drivers/usb/chipidea/udc.c | 2 +-
> drivers/usb/dwc3/core.c | 4 +-
> drivers/usb/gadget/fsl_udc_core.c | 2 +-
> drivers/usb/gadget/mv_udc_core.c | 2 +-
> drivers/usb/gadget/omap_udc.c | 2 +-
> drivers/usb/gadget/pxa25x_udc.c | 2 +-
> drivers/usb/gadget/pxa27x_udc.c | 2 +-
> drivers/usb/gadget/s3c-hsudc.c | 2 +-
> drivers/usb/host/ehci-fsl.c | 2 +-
> drivers/usb/host/ehci-msm.c | 2 +-
> drivers/usb/host/ehci-mv.c | 2 +-
> drivers/usb/host/ehci-tegra.c | 2 +-
> drivers/usb/host/ohci-omap.c | 2 +-
> drivers/usb/musb/am35x.c | 2 +-
> drivers/usb/musb/blackfin.c | 2 +-
> drivers/usb/musb/da8xx.c | 2 +-
> drivers/usb/musb/davinci.c | 2 +-
> drivers/usb/musb/musb_dsps.c | 2 +-
> drivers/usb/musb/omap2430.c | 2 +-
> drivers/usb/musb/tusb6010.c | 2 +-
> drivers/usb/musb/ux500.c | 2 +-
> drivers/usb/otg/ab8500-usb.c | 3 +-
> drivers/usb/otg/fsl_otg.c | 5 ++-
> drivers/usb/otg/gpio_vbus.c | 3 +-
> drivers/usb/otg/isp1301_omap.c | 3 +-
> drivers/usb/otg/msm_otg.c | 3 +-
> drivers/usb/otg/mv_otg.c | 3 +-
> drivers/usb/otg/nop-usb-xceiv.c | 3 +-
> drivers/usb/otg/otg.c | 67 +++++++++++++++------------------
> drivers/usb/otg/twl4030-usb.c | 3 +-
> drivers/usb/phy/mv_u3d_phy.c | 3 +-
> drivers/usb/phy/omap-usb2.c | 11 ++----
> drivers/usb/phy/rcar-phy.c | 3 +-
> include/linux/usb/phy.h | 12 +++---
> 39 files changed, 87 insertions(+), 89 deletions(-)
I think it better to leave the existing add/get APIs as they are add add
new APIs that support multiple PHYs. You could probably mark the old
ones as deprecated.
That way you don't need to wait till all users are converted and tested.
e.g. you could name the new APIs as
usb_add_phy_dev(struct usb_phy *phy);
usb_get_phy_dev(struct device *dev, int index);
--
cheers,
-roger
next prev parent reply other threads:[~2013-01-17 16:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 15:00 [RFC PATCH 0/6] USB: Add multiple PHYs of same type Kishon Vijay Abraham I
2013-01-16 15:00 ` [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY Kishon Vijay Abraham I
2013-01-17 9:37 ` Roger Quadros
2013-01-17 11:14 ` kishon
2013-01-18 11:48 ` Felipe Balbi
2013-01-16 15:00 ` [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information Kishon Vijay Abraham I
2013-01-17 9:39 ` Roger Quadros
2013-01-17 11:03 ` kishon
2013-01-17 12:11 ` Vivek Gautam
2013-01-17 12:31 ` kishon
2013-01-17 13:11 ` Vivek Gautam
2013-01-16 15:00 ` [RFC PATCH 3/6] usb: otg: utils: change the phy lib to support multiple PHYs of same type Kishon Vijay Abraham I
2013-01-17 0:31 ` Simon Horman
2013-01-17 16:07 ` Roger Quadros [this message]
2013-01-18 5:28 ` kishon
2013-01-16 15:01 ` [RFC PATCH 4/6] ARM: dts: OMAP: Add phandle to bind PHY with USB controller Kishon Vijay Abraham I
2013-01-16 15:01 ` [RFC PATCH 5/6] usb: otg: add device tree support to otg library Kishon Vijay Abraham I
2013-01-21 13:21 ` Roger Quadros
2013-01-21 13:34 ` kishon
2013-01-21 14:23 ` Roger Quadros
2013-01-16 15:01 ` [RFC PATCH 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot Kishon Vijay Abraham I
2013-01-21 13:18 ` Roger Quadros
2013-01-21 13:41 ` kishon
2013-01-21 14:24 ` Roger Quadros
2013-01-18 11:48 ` [RFC PATCH 0/6] USB: Add multiple PHYs of same type Felipe Balbi
2013-01-18 11:54 ` kishon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F821DD.1040609@ti.com \
--to=rogerq@ti.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=cbou@mail.ru \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dwmw2@infradead.org \
--cc=eric.y.miao@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=haojian.zhuang@gmail.com \
--cc=horms@verge.net.au \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).