linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, m8@semihalf.com
Subject: Re: [RFC/POWERPC] mpc5200: remove "mpc5200b-*" from compatible lists in dts files
Date: Sat, 19 Apr 2008 11:23:57 +0200	[thread overview]
Message-ID: <50bbe43673e46cc8d3a02eb4c03d87e9@kernel.crashing.org> (raw)
In-Reply-To: <20080418161218.12738.25844.stgit@trillian.secretlab.ca>

> The mpc5200b is a bug fix of the mpc5200 with a few incompatible 
> changes.
> By rights, the current dts trees are the most "correct", but in 
> practical
> purposes there is no value in the 5200b devices having 2 compatible
> entries for each internal peripheral node.  Freescale has done a good 
> job
> of documenting exactly where the incompatibilities lie, so it restrict
> the extra compatible properties to devices with *documented* changes.

And what happens when later an "undocumented change" is found?  The
device tree should always list the exact version of device used, even
if all clients (i.e., the Linux kernel) only use the less-specific
"compatible" value; that way, if a need to distinguish arises later
(e.g., a model-specific bug workaround), a client can detect the exact
model of device without needing a new device tree (that the client in
general has no control over).

> Removing the extra 'b' fields makes the device trees smaller

That's nice in general, but it hardly overrides more serious concerns.


Segher

  reply	other threads:[~2008-04-19  9:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-18 16:13 [RFC/POWERPC] mpc5200: remove "mpc5200b-*" from compatible lists in dts files Grant Likely
2008-04-19  9:23 ` Segher Boessenkool [this message]
2008-04-19 16:23   ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50bbe43673e46cc8d3a02eb4c03d87e9@kernel.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=m8@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).