From: Timur Tabi <timur.tabi@calxeda.com>
To: Stef van Os <stef.van.os@prodrive.nl>
Cc: Scott Wood <scottwood@freescale.com>,
Paul Mackerras <paulus@samba.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v2 1/1] powerpc/85xx: Board support for ppa8548
Date: Mon, 04 Feb 2013 09:30:26 -0600 [thread overview]
Message-ID: <510FD412.4000505@calxeda.com> (raw)
In-Reply-To: <1359920347-15340-1-git-send-email-stef.van.os@prodrive.nl>
On 02/03/2013 01:39 PM, Stef van Os wrote:
> + pci0: pci@fe0008000 {
> + status = "disabled";
> + };
> +
> + pci1: pci@fe0009000 {
> + status = "disabled";
> + };
> +
> + pci2: pcie@fe000a000 {
> + status = "disabled";
> + };
I was hoping you'd follow my example and include a comment indicating
why the PCI devices are all disabled.
> +static void ppa8548_show_cpuinfo(struct seq_file *m)
> +{
> + uint svid, phid1;
Please don't used unsized integers for hardware registers.
uint32_t svid, phid1;
--
Timur Tabi
next prev parent reply other threads:[~2013-02-04 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-03 19:39 [PATCH v2 1/1] powerpc/85xx: Board support for ppa8548 Stef van Os
2013-02-04 15:30 ` Timur Tabi [this message]
2013-02-12 20:09 ` Kumar Gala
2013-02-13 14:03 ` Stef van Os
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510FD412.4000505@calxeda.com \
--to=timur.tabi@calxeda.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
--cc=stef.van.os@prodrive.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).