public inbox for linuxppc-dev@ozlabs.org
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.ibm.com>
To: "Mukesh Kumar Chaurasiya (IBM)" <mkchauras@gmail.com>,
	linkmauve@linkmauve.fr, ojeda@kernel.org, boqun.feng@gmail.com,
	gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org,
	a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
	dakr@kernel.org, corbet@lwn.net, mpe@ellerman.id.au,
	npiggin@gmail.com, chleroy@kernel.org, peterz@infradead.org,
	jpoimboe@kernel.org, jbaron@akamai.com, rostedt@goodmis.org,
	ardb@kernel.org, rust-for-linux@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V6 0/3] Rust support for powerpc
Date: Wed, 25 Mar 2026 13:59:55 +0530	[thread overview]
Message-ID: <51269463-8538-4149-a3f3-156a5c4d49b4@linux.ibm.com> (raw)
In-Reply-To: <20260210090023.2587534-1-mkchauras@gmail.com>


On 2/10/26 2:30 PM, Mukesh Kumar Chaurasiya (IBM) wrote:
> Enable experimental rust support for ppc64le and ppc32be. The patch for
> ppc32 has been provided by Link Mauve[1] and ppc64le support[2] has been
> merged over it. ppc32 needs some toolchain fixes mentioned in the patch
> `rust: Add PowerPC support` and the discussion for that is done here[1].
>
> This has been tested on powernv9 hardware and power10 pseries qemu. I
> I request Link to test the ppc32 part as i don't have a hardware to test
> it out.
>
> [1] https://lore.kernel.org/all/20260204030507.8203-1-linkmauve@linkmauve.fr
> [2] https://lore.kernel.org/all/20260204042417.83903-1-mkchauras@gmail.com

Could see these build issues with the Rust patchset in the compilation 
of powerpc-next-test
This happens when compilation happens only with few threads

# rustc --version
rustc 1.94.0 (4a4ef493e 2026-03-02)

....
   EXPORTS rust/exports_core_generated.h
   BINDGEN rust/bindings/bindings_generated.rs
   BINDGEN rust/bindings/bindings_helpers_generated.rs
   CC      rust/helpers/helpers.o
   EXPORTS rust/exports_helpers_generated.h
   RUSTC L rust/compiler_builtins.o
   RUSTC L rust/ffi.o
   RUSTC PL rust/libproc_macro2.rlib
error[E0464]: multiple candidates for `rmeta` dependency `core` found
  --> rust/proc-macro2/marker.rs:4:5
   |
4 | use core::marker::PhantomData;
   |     ^^^^
   |
   = note: candidate #1: 
/root/.rustup/toolchains/nightly-powerpc64le-unknown-linux-gnu/lib/rustlib/powerpc64le-unknown-linux-gnu/lib/libcore-951759db375eea0c.rmeta
   = note: candidate #2: ./rust/libcore.rmeta

error[E0119]: conflicting implementations of trait `PartialEq` for type 
`fallback::Ident`
    --> rust/proc-macro2/fallback.rs:875:1
     |
869 |   impl PartialEq for Ident {
     |   ------------------------ first implementation here
...
875 | / impl<T> PartialEq<T> for Ident
876 | | where
877 | |     T: ?Sized + AsRef<str>,
     | |___________________________^ conflicting implementation for 
`fallback::Ident`

error[E0277]: `LexError` doesn't implement `std::fmt::Display`
    --> rust/proc-macro2/lib.rs:347:16
     |
347 | impl Error for LexError {}
     |                ^^^^^^^^ unsatisfied trait bound
     |
help: the trait `std::fmt::Display` is not implemented for `LexError`
    --> rust/proc-macro2/lib.rs:204:1
     |
204 | pub struct LexError {
     | ^^^^^^^^^^^^^^^^^^^
note: required by a bound in `std::error::Error`
    --> 
/root/.rustup/toolchains/nightly-powerpc64le-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/error.rs:59:26
     |
  59 | pub trait Error: Debug + Display {
     |                          ^^^^^^^ required by this bound in `Error`

error[E0277]: `LexError` doesn't implement `Debug`
    --> rust/proc-macro2/lib.rs:347:16
     |
347 | impl Error for LexError {}
     |                ^^^^^^^^ unsatisfied trait bound
     |
help: the trait `Debug` is not implemented for `LexError`
    --> rust/proc-macro2/lib.rs:204:1
     |
204 | pub struct LexError {
     | ^^^^^^^^^^^^^^^^^^^
     = note: add `#[derive(Debug)]` to `LexError` or manually `impl 
Debug for LexError`
note: required by a bound in `std::error::Error`
    --> 
/root/.rustup/toolchains/nightly-powerpc64le-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/error.rs:59:18
     |
  59 | pub trait Error: Debug + Display {
     |                  ^^^^^ required by this bound in `Error`

error: aborting due to 4 previous errors

......
But when parallelized with more threads (-j 128) compilation passes with 
out any error
There is some ordering of libcore is messing up I guess (I could be wrong)
(I have removed the warning of unstable features messages here for 
cleaner output)

....
   VDSO64SYM include/generated/vdso64-offsets.h
   RUSTC L rust/core.o
   BINDGEN rust/bindings/bindings_generated.rs
   BINDGEN rust/bindings/bindings_helpers_generated.rs
   CC      rust/helpers/helpers.o
   RUSTC PL rust/libproc_macro2.rlib
   BINDGEN rust/uapi/uapi_generated.rs
   RSCPP     rust/kernel/generated_arch_static_branch_asm.rs
   RSCPP     rust/kernel/generated_arch_warn_asm.rs
   RSCPP     rust/kernel/generated_arch_reachable_asm.rs
clang diag: ./arch/powerpc/include/uapi/asm/ioctl.h:5:9: warning: 
'_IOC_SIZEBITS' macro redefined [-Wmacro-redefined]
clang diag: ./arch/powerpc/include/uapi/asm/ioctl.h:6:9: warning: 
'_IOC_DIRBITS' macro redefined [-Wmacro-redefined]
clang diag: ./arch/powerpc/include/uapi/asm/ioctl.h:8:9: warning: 
'_IOC_NONE' macro redefined [-Wmacro-redefined]
clang diag: ./arch/powerpc/include/uapi/asm/ioctl.h:10:9: warning: 
'_IOC_WRITE' macro redefined [-Wmacro-redefined]
   EXPORTS rust/exports_helpers_generated.h
   RUSTC PL rust/libquote.rlib
   RUSTC PL rust/libsyn.rlib
   RUSTC P rust/libpin_init_internal.so
   RUSTC P rust/libmacros.so
   EXPORTS rust/exports_core_generated.h
   RUSTC L rust/compiler_builtins.o
   RUSTC L rust/ffi.o
   RUSTC L rust/pin_init.o
   RUSTC L rust/build_error.o
   RUSTC L rust/bindings.o
   RUSTC L rust/uapi.o
   EXPORTS rust/exports_bindings_generated.h
   RUSTC L rust/kernel.o
   EXPORTS rust/exports_kernel_generated.h
   LDS     scripts/module.lds
   HOSTCC  usr/gen_init_cpio
   CC      init/main.o
....

Also I see some errors when compiling modules. I am looking at these and 
any help is welcome.
I will pull out Rust patches for now from powerpc-linux next-test branch 
and once this is
restored I will add these patches back to branch for the merge.

Maddy

> Changelog:
> V5 -> V6:
> - Added a missing Tested by from Venkat which got missed since V3
> - Support is marked as Maintained instead of experimental
> V5: https://lore.kernel.org/all/20260210053756.2088302-1-mkchauras@gmail.com
>
> V4 -> V5:
> - Removed a nested ifdef from PPC64 for Little endian toolchain
> V4: https://lore.kernel.org/all/20260209105456.1551677-1-mkchauras@gmail.com
>
> V3 -> V4:
> - Co-developed-by header added in patch 1
> V3: https://lore.kernel.org/all/20260205180429.3280657-1-mkchauras@gmail.com
>
> V2 -> V3:
> - Splited HAVE_RUST in 2 lines
> - BINDGEN_TARGET_powerpc initialized before assigning the same to
>    BINDGEN_TARGET
> V2: https://lore.kernel.org/all/20260204210125.613350-1-mkchauras@gmail.com
>
> V1 -> V2:
> - jump label fix for rust has been moved to a separate patch
> - PPC32 support has been taken
> - rust support has been marked experimental
> - target.json dependency has been removed
> - HAVE_RUST now depends on CPU_LITTLE_ENDIAN for PPC64
>
>
> Link Mauve (1):
>    rust: Add PowerPC support
>
> Mukesh Kumar Chaurasiya (IBM) (2):
>    powerpc/jump_label: adjust inline asm to be consistent
>    powerpc: Enable Rust for ppc64le
>
>   Documentation/rust/arch-support.rst   |  1 +
>   arch/powerpc/Kconfig                  |  2 ++
>   arch/powerpc/Makefile                 |  7 +++++++
>   arch/powerpc/include/asm/jump_label.h | 23 +++++++++++++----------
>   rust/Makefile                         | 10 +++++++++-
>   5 files changed, 32 insertions(+), 11 deletions(-)
>


  parent reply	other threads:[~2026-03-25  8:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10  9:00 [PATCH V6 0/3] Rust support for powerpc Mukesh Kumar Chaurasiya (IBM)
2026-02-10  9:00 ` [PATCH V6 1/3] powerpc/jump_label: adjust inline asm to be consistent Mukesh Kumar Chaurasiya (IBM)
2026-02-10  9:00 ` [PATCH V6 2/3] rust: Add PowerPC support Mukesh Kumar Chaurasiya (IBM)
2026-02-22 18:09   ` Alice Ryhl
2026-02-22 19:07     ` Link Mauve
2026-02-22 19:11       ` Miguel Ojeda
2026-02-23  2:21         ` Mukesh Kumar Chaurasiya
2026-02-23  2:26         ` Mukesh Kumar Chaurasiya
2026-02-23  9:22           ` Alice Ryhl
2026-02-24  4:57             ` Mukesh Kumar Chaurasiya
2026-02-23 15:31           ` Miguel Ojeda
2026-02-24  4:59             ` Mukesh Kumar Chaurasiya
2026-02-24  8:58             ` Ralf Jung
2026-03-02  5:55               ` Mukesh Kumar Chaurasiya
2026-03-02  7:29                 ` Alice Ryhl
2026-03-02 12:28                   ` Ralf Jung
2026-02-10  9:00 ` [PATCH V6 3/3] powerpc: Enable Rust for ppc64le Mukesh Kumar Chaurasiya (IBM)
2026-03-25  8:29 ` Madhavan Srinivasan [this message]
2026-03-26 22:16   ` [PATCH V6 0/3] Rust support for powerpc Mukesh Kumar Chaurasiya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51269463-8538-4149-a3f3-156a5c4d49b4@linux.ibm.com \
    --to=maddy@linux.ibm.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=ardb@kernel.org \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=chleroy@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dakr@kernel.org \
    --cc=gary@garyguo.net \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@kernel.org \
    --cc=linkmauve@linkmauve.fr \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=lossin@kernel.org \
    --cc=mkchauras@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=tmgross@umich.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox