From: "tiejun.chen" <tiejun.chen@windriver.com>
To: Alex Grad <alex.grad@gmail.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jason Wessel <jason.wessel@windriver.com>
Cc: sfr@canb.auug.org.au, mikey@neuling.org, daniel.baluta@gmail.com,
linux-kernel@vger.kernel.org, penberg@kernel.org,
paulus@samba.org, jason.wessel@windriver.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast
Date: Mon, 11 Mar 2013 09:33:34 +0800 [thread overview]
Message-ID: <513D346E.20009@windriver.com> (raw)
In-Reply-To: <1362955188-3023-1-git-send-email-alex.grad@gmail.com>
On 03/11/2013 06:39 AM, Alex Grad wrote:
> While at it, check kmalloc return value.
>
> Signed-off-by: Alex Grad <alex.grad@gmail.com>
> ---
> arch/powerpc/kernel/kgdb.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c
> index 5ca82cd..9e81dd8 100644
> --- a/arch/powerpc/kernel/kgdb.c
> +++ b/arch/powerpc/kernel/kgdb.c
> @@ -159,7 +159,10 @@ static int kgdb_singlestep(struct pt_regs *regs)
> if (user_mode(regs))
> return 0;
>
> - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL);
> + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL);
> + if (!backup_current_thread_info)
> + return -ENOMEM;
I already send a kgdb patchset in "[v3][PATCH 6/6] powerpc/kgdb: remove copying
the thread_info" to remove these stuff since its unnecessary to copy current
thread_info now.
Tiejun
next prev parent reply other threads:[~2013-03-11 1:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 22:39 [PATCH]->[PATCH v2] kgdb: Removed kmalloc returned value cast Alex Grad
2013-03-11 1:33 ` tiejun.chen [this message]
2013-03-11 10:14 ` tiejun.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513D346E.20009@windriver.com \
--to=tiejun.chen@windriver.com \
--cc=alex.grad@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=daniel.baluta@gmail.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).