* [PATCH] powerpc/dts: Add qe support for 36bit
@ 2013-03-21 9:26 Zhicheng Fan
2013-03-21 18:42 ` Timur Tabi
0 siblings, 1 reply; 4+ messages in thread
From: Zhicheng Fan @ 2013-03-21 9:26 UTC (permalink / raw)
To: galak, linuxppc-dev; +Cc: Zhicheng Fan
fixed the following errors:
Error: arch/powerpc/boot/dts/p1025rdb.dtsi:326.2-3 label or path, 'qe', not found
Error: arch/powerpc/boot/dts/fsl/p1021si-post.dtsi:242.2-3 label or path, 'qe', not found
FATAL ERROR: Syntax error parsing input tree
Signed-off-by: Zhicheng Fan <B32736@freescale.com>
---
arch/powerpc/boot/dts/p1025rdb_36b.dts | 48 ++++++++++++++++++++++++++++++++
1 files changed, 48 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/p1025rdb_36b.dts b/arch/powerpc/boot/dts/p1025rdb_36b.dts
index 4ce4bfa..c74c39b 100644
--- a/arch/powerpc/boot/dts/p1025rdb_36b.dts
+++ b/arch/powerpc/boot/dts/p1025rdb_36b.dts
@@ -82,6 +82,54 @@
0x0 0x100000>;
};
};
+
+ qe: qe@fffe80000 {
+ ranges = <0x0 0xf 0xffe80000 0x40000>;
+ reg = <0xf 0xffe80000 0 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <0>;
+ status = "disabled"; /* no firmware loaded */
+
+ enet3: ucc@2000 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ rx-clock-name = "clk12";
+ tx-clock-name = "clk9";
+ pio-handle = <&pio1>;
+ phy-handle = <&qe_phy0>;
+ phy-connection-type = "mii";
+ };
+
+ mdio@2120 {
+ qe_phy0: ethernet-phy@0 {
+ interrupt-parent = <&mpic>;
+ interrupts = <4 1 0 0>;
+ reg = <0x6>;
+ device_type = "ethernet-phy";
+ };
+ qe_phy1: ethernet-phy@03 {
+ interrupt-parent = <&mpic>;
+ interrupts = <5 1 0 0>;
+ reg = <0x3>;
+ device_type = "ethernet-phy";
+ };
+ tbi-phy@11 {
+ reg = <0x11>;
+ device_type = "tbi-phy";
+ };
+ };
+
+ enet4: ucc@2400 {
+ device_type = "network";
+ compatible = "ucc_geth";
+ rx-clock-name = "none";
+ tx-clock-name = "clk13";
+ pio-handle = <&pio2>;
+ phy-handle = <&qe_phy1>;
+ phy-connection-type = "rmii";
+ };
+ };
+
};
/include/ "p1025rdb.dtsi"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/dts: Add qe support for 36bit
2013-03-21 9:26 [PATCH] powerpc/dts: Add qe support for 36bit Zhicheng Fan
@ 2013-03-21 18:42 ` Timur Tabi
2013-03-22 7:16 ` Zhicheng Fan
0 siblings, 1 reply; 4+ messages in thread
From: Timur Tabi @ 2013-03-21 18:42 UTC (permalink / raw)
To: Zhicheng Fan; +Cc: linuxppc-dev
On Thu, Mar 21, 2013 at 4:26 AM, Zhicheng Fan <B32736@freescale.com> wrote:
> + qe: qe@fffe80000 {
> + ranges = <0x0 0xf 0xffe80000 0x40000>;
Are you sure this works? The QE can't handle 36-bit addresses, and I
think the MURAM is located inside the QE address space.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/dts: Add qe support for 36bit
2013-03-21 18:42 ` Timur Tabi
@ 2013-03-22 7:16 ` Zhicheng Fan
2013-03-22 11:50 ` Timur Tabi
0 siblings, 1 reply; 4+ messages in thread
From: Zhicheng Fan @ 2013-03-22 7:16 UTC (permalink / raw)
To: Timur Tabi; +Cc: linuxppc-dev
On 03/22/2013 02:42 AM, Timur Tabi wrote:
> On Thu, Mar 21, 2013 at 4:26 AM, Zhicheng Fan <B32736@freescale.com> wrote:
>> + qe: qe@fffe80000 {
>> + ranges = <0x0 0xf 0xffe80000 0x40000>;
> Are you sure this works? The QE can't handle 36-bit addresses, and I
> think the MURAM is located inside the QE address space.
>
Hi Timur,
you are right ,the QE can not support the 36-bit , I test it on
the p1025 ,the qe can not work
but we need the qe node , becase the dts include the
fsl/p1021si-post.dtsi
that needed, I will send other patch
--
Regards & Thanks
Zhicheng Fan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/dts: Add qe support for 36bit
2013-03-22 7:16 ` Zhicheng Fan
@ 2013-03-22 11:50 ` Timur Tabi
0 siblings, 0 replies; 4+ messages in thread
From: Timur Tabi @ 2013-03-22 11:50 UTC (permalink / raw)
To: Zhicheng Fan; +Cc: linuxppc-dev
Zhicheng Fan wrote:
>>
> Hi Timur,
> you are right ,the QE can not support the 36-bit , I test it on
> the p1025 ,the qe can not work
> but we need the qe node , becase the dts include the
> fsl/p1021si-post.dtsi
> that needed, I will send other patch
My suggestion: with a 36-bit device tree, the QE must be disabled.
qe: qe@fffe80000 {
/* The QE does not work with 36-bit addressing */
status = "disabled";
};
However, on the P102x, there may be a GUTS register that stores the upper
four bits of the QE's physical address. Your patch *can* work if you
*also* set this register to 0xF. Look for that register.
--
Timur Tabi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-22 11:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-21 9:26 [PATCH] powerpc/dts: Add qe support for 36bit Zhicheng Fan
2013-03-21 18:42 ` Timur Tabi
2013-03-22 7:16 ` Zhicheng Fan
2013-03-22 11:50 ` Timur Tabi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).