From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Soeren Moch <smoch@web.de>, Paul Mackerras <paulus@samba.org>,
linux-arm-kernel@lists.infradead.org,
Dale Farnsworth <dale@farnsworth.org>,
netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Florian Fainelli <florian@openwrt.org>,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH] net: mv643xx_eth: Add GRO support
Date: Thu, 11 Apr 2013 20:07:16 +0200 [thread overview]
Message-ID: <5166FBD4.5020508@gmail.com> (raw)
In-Reply-To: <1365702955.7355.5.camel@bwh-desktop.uk.solarflarecom.com>
On 04/11/2013 07:55 PM, Ben Hutchings wrote:
> On Thu, 2013-04-11 at 14:40 +0200, Sebastian Hesselbarth wrote:
>> This patch adds GRO support to mv643xx_eth by making it invoke
>> napi_gro_receive instead of netif_receive_skb.
>
> The inet_lro support should be removed at the same time; inet_lro is now
> deprecated and there should be no need to keep both of them.
Ben,
I agree on removing it asap, but I also like to see GRO support
in. Maybe, we postpone lro removal just a little bit. I have just
started to look at mv643xx_eth and remember Marvell Orion SoCs are
not the only platform using it. I haven't heard a single word from
ppc guys, yet.
Willy just posted an experimental patch to remove lro. I'll have
a look at it and test it out on Dove.
Sebastian
next prev parent reply other threads:[~2013-04-11 18:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 12:40 [PATCH] net: mv643xx_eth: Add GRO support Sebastian Hesselbarth
2013-04-11 13:13 ` Willy Tarreau
2013-04-11 14:47 ` Sebastian Hesselbarth
2013-04-11 15:03 ` Willy Tarreau
2013-04-11 15:27 ` Sebastian Hesselbarth
2013-04-11 15:32 ` Willy Tarreau
2013-04-11 15:54 ` Eric Dumazet
2013-04-11 16:02 ` Willy Tarreau
2013-04-11 16:10 ` Eric Dumazet
2013-04-11 16:59 ` Sebastian Hesselbarth
2013-04-11 17:13 ` Willy Tarreau
2013-04-11 17:31 ` David Miller
2013-04-11 17:35 ` Eric Dumazet
2013-04-11 17:51 ` Willy Tarreau
2013-04-11 17:59 ` Eric Dumazet
2013-04-11 18:02 ` Willy Tarreau
2013-04-11 15:54 ` Eric Dumazet
2013-04-11 17:55 ` Ben Hutchings
2013-04-11 18:07 ` Sebastian Hesselbarth [this message]
2013-04-11 20:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166FBD4.5020508@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=andrew@lunn.ch \
--cc=bhutchings@solarflare.com \
--cc=buytenh@wantstofly.org \
--cc=dale@farnsworth.org \
--cc=davem@davemloft.net \
--cc=florian@openwrt.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=smoch@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).