From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ea0-x230.google.com (mail-ea0-x230.google.com [IPv6:2a00:1450:4013:c01::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id F04062C00A4 for ; Thu, 23 May 2013 03:42:43 +1000 (EST) Received: by mail-ea0-f176.google.com with SMTP id k11so1333789eaj.35 for ; Wed, 22 May 2013 10:42:39 -0700 (PDT) Message-ID: <519D038C.9000605@gmail.com> Date: Wed, 22 May 2013 19:42:36 +0200 From: Sebastian Hesselbarth MIME-Version: 1.0 To: Jason Cooper Subject: Re: [PATCH v4 06/12] ARM: dove: add gigabit ethernet and mvmdio device tree nodes References: <1367854420-8006-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369154510-4927-1-git-send-email-sebastian.hesselbarth@gmail.com> <1369154510-4927-7-git-send-email-sebastian.hesselbarth@gmail.com> <20130521174849.GL26249@lunn.ch> <519C9333.20609@gmail.com> <519C9822.9040909@windriver.com> <519C9A66.3050807@gmail.com> <20130522131010.GB31290@titan.lakedaemon.net> <20130522165908.GB12320@obsidianresearch.com> <519D0143.1000203@gmail.com> <20130522173505.GH31290@titan.lakedaemon.net> In-Reply-To: <20130522173505.GH31290@titan.lakedaemon.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Andrew Lunn , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe , "tiejun.chen" , Lennert Buytenhek , linuxppc-dev@lists.ozlabs.org, David Miller , linux-arm-kernel@lists.infradead.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 05/22/2013 07:35 PM, Jason Cooper wrote: > On Wed, May 22, 2013 at 07:32:51PM +0200, Sebastian Hesselbarth wrote: >> On 05/22/2013 06:59 PM, Jason Gunthorpe wrote: >>> On Wed, May 22, 2013 at 09:10:10AM -0400, Jason Cooper wrote: >>>> iirc, our solution to this was to parse the ATAGs for the mac addr and >>>> update the appended dtb. This way, module load and unload would work >>>> without loosing the mac address. I believe Jason Gunthorpe has a patch >>>> to atags_to_fdt() for this... This should allow us to get rid of the >>>> clocks hack. >>> >>> Sorry, no, we don't use ATAGs here, our platforms start the kernel >>> with a correct DTB that has the correct mac address to use. My patch >>> was to have the driver accept it, and I think Sebastian has already >>> got that functionality... >> >> Not neccessary anyway, after talking Jason C in a Kirkwood-only >> workaround I prepared a patch that reads mac address registers early >> and stores it in the local-mac-address property. > > Sweet! > >> Just tested on Dockstar with gated clocks and modular DT mv643xx_eth. >> >> Will append to the DT mv643xx_eth patch set if a v5 will be required >> or as single patch prior Jason C taking in the ARM part of it >> otherwise. > > Please post, in-reply-to v4 is fine. Hmm, maybe a little bit too early. While restoring the MAC address now works, another bug arises which I guess is related with phy setup and aneg. Will investigate and update patch set accordingly. Sebastian