From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [119.145.14.65]) (using TLSv1 with cipher DES-CBC3-SHA (168/168 bits)) (Client CN "myname.my.domain", Issuer "www.mirapoint.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 9203B2C0345 for ; Wed, 29 May 2013 12:40:38 +1000 (EST) Message-ID: <51A568EC.2070103@huawei.com> Date: Wed, 29 May 2013 10:33:16 +0800 From: Libo Chen MIME-Version: 1.0 To: , Greg KH Subject: [PATCH] driver: tty: add missing unregister in err case Content-Type: text/plain; charset="ISO-8859-1" Cc: jslaby@suse.cz, linux-kernel@vger.kernel.org, Rob Herring , Li Zefan , linux-serial@vger.kernel.org, Grant Likely , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , when platform_driver_register broken, we should unregister ucc_uart_driver Signed-off-by: Libo chen --- drivers/tty/serial/ucc_uart.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c index 7355303..f86f447 100644 --- a/drivers/tty/serial/ucc_uart.c +++ b/drivers/tty/serial/ucc_uart.c @@ -1518,9 +1518,11 @@ static int __init ucc_uart_init(void) } ret = platform_driver_register(&ucc_uart_of_driver); - if (ret) + if (ret) { printk(KERN_ERR "ucc-uart: could not register platform driver\n"); + uart_unregister_driver(&ucc_uart_driver); + } return ret; } -- 1.7.1