From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp02.in.ibm.com (e28smtp02.in.ibm.com [122.248.162.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e28smtp02.in.ibm.com", Issuer "GeoTrust SSL CA" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 9CCBF2C01D4 for ; Wed, 5 Jun 2013 19:00:42 +1000 (EST) Received: from /spool/local by e28smtp02.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Jun 2013 14:23:27 +0530 Received: from d28relay02.in.ibm.com (d28relay02.in.ibm.com [9.184.220.59]) by d28dlp01.in.ibm.com (Postfix) with ESMTP id E0845E004F for ; Wed, 5 Jun 2013 14:33:21 +0530 (IST) Received: from d28av04.in.ibm.com (d28av04.in.ibm.com [9.184.220.66]) by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5590Swh51052794 for ; Wed, 5 Jun 2013 14:30:28 +0530 Received: from d28av04.in.ibm.com (loopback [127.0.0.1]) by d28av04.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5590TZh024453 for ; Wed, 5 Jun 2013 19:00:32 +1000 Message-ID: <51AEFE28.3040104@linux.vnet.ibm.com> Date: Wed, 05 Jun 2013 14:30:24 +0530 From: Aruna Balakrishnaiah MIME-Version: 1.0 To: Benjamin Herrenschmidt Subject: Re: [PATCH v3 0/8] Nvram-to-pstore References: <20130425100952.21017.51799.stgit@aruna-ThinkPad-T420> <1370064348.3766.37.camel@pasglop> In-Reply-To: <1370064348.3766.37.camel@pasglop> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: jkenisto@linux.vnet.ibm.com, tony.luck@intel.com, keescook@chromium.org, mahesh@linux.vnet.ibm.com, ccross@android.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, paulus@samba.org, anton@samba.org, cbouatmailru@gmail.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Ben, On Saturday 01 June 2013 10:55 AM, Benjamin Herrenschmidt wrote: > Another question... > > Should the core pstore fail to unlink partitions that don't have > an ->erase callback ? IE. Why would you let anyone erase the OFW > common partition for example ? That means that userspace tools > can no longer manipulate it but we certainly don't want to remove > it from the nvram itself. Since I do not have a callback for erase in nvram, pstore simply unlinks the file and will not delete the partition. > > That leads to a deeper concern. Looking at how efi-pstore works, > it looks like they create a file for each var. > > This looks like something valuable we could do for something like > the common partition since typically it's made of name,value pairs. > > However, pstore is a flat space, while we have patitions which > themselves can be organized in name,value pairs (some at least) > > I wonder if it's time to introduce pstore directories... Or do > we stick to our special tools to interpret/change the name,value > pairs ? Since pstore infrastructure creates the file in read-only mode creating files for name, value pairs will not be useful to us. So for now, we need to stick to our tools to interpret/change the name,value pairs. And also, pstore filenames are controlled by pstore infrastructure so that would need quite some changes in the pstore infrastructure. I think for now it would be better to dump the contents of common partition as it is. > > Also do we want to add an ability to resize partitions ? Possibly > based on how much is written to them ? Yes it will be good to that. If your fine with patchset apart from the filenames of-config and common partitions. I will post the next version of it with powerpc prefix. > > Cheers, > Ben. > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev >