From: Lian Minghuan-b31939 <B31939@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Minghuan Lian <Minghuan.Lian@freescale.com>,
linuxppc-dev@lists.ozlabs.org,
Zang Roy-R61911 <r61911@freescale.com>
Subject: Re: [PATCH 1/5] powerpc/dts: add MPIC v4.3 dts node
Date: Mon, 17 Jun 2013 10:23:37 +0800 [thread overview]
Message-ID: <51BE7329.8070304@freescale.com> (raw)
In-Reply-To: <1371246799.2996.14@snotra>
Hi Scott,
please see my comments.
On 06/15/2013 05:53 AM, Scott Wood wrote:
> On 06/14/2013 03:39:26 PM, Scott Wood wrote:
>> On 06/14/2013 02:15:55 AM, Minghuan Lian wrote:
>>> +msi0: msi@41600 {
>>> + compatible = "fsl,mpic-msi", "fsl,mpic-msi-v4.3";
>>
>> More specific compatibles come first -- and I don't think this is
>> 100% backwards compatible with "fsl,mpic-msi" anyway.
>
> Also please update the binding.
[Minghuan] Yes, maybe I should remove "fsl,mpic-msi". What do you think?
>
> -Scott
next prev parent reply other threads:[~2013-06-17 2:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 7:15 [PATCH 1/5] powerpc/dts: add MPIC v4.3 dts node Minghuan Lian
2013-06-14 7:15 ` [PATCH 2/5] powerpc/fsl_msi: add MSIIR1 support for MPIC v4.3 Minghuan Lian
2013-06-14 22:09 ` Scott Wood
2013-06-17 3:00 ` Lian Minghuan-b31939
2013-06-18 0:15 ` Scott Wood
2013-06-18 2:34 ` Lian Minghuan-b31939
2013-06-18 18:08 ` Scott Wood
2013-06-14 7:15 ` [PATCH 3/5] powerpc/dts: update MSI bindings doc " Minghuan Lian
2013-06-14 22:06 ` Scott Wood
2013-06-17 5:07 ` Lian Minghuan-b31939
2013-06-18 0:28 ` Scott Wood
2013-06-18 0:42 ` Scott Wood
2013-06-18 2:49 ` Lian Minghuan-b31939
2013-06-18 16:21 ` Scott Wood
2013-06-14 7:15 ` [PATCH 4/5] powerpc/dts: remove msi-available-ranges property Minghuan Lian
2013-06-14 22:10 ` Scott Wood
2013-06-17 5:15 ` Lian Minghuan-b31939
2013-06-18 0:13 ` Scott Wood
2013-06-14 7:15 ` [PATCH 5/5] powerpc/fsl_msi: add 'msiregs' kernel parameter Minghuan Lian
2013-06-14 22:13 ` Scott Wood
2013-06-17 5:36 ` Lian Minghuan-b31939
2013-06-18 0:18 ` Scott Wood
2013-06-18 3:10 ` Lian Minghuan-b31939
2013-06-18 16:22 ` Scott Wood
2013-06-14 20:39 ` [PATCH 1/5] powerpc/dts: add MPIC v4.3 dts node Scott Wood
2013-06-14 21:53 ` Scott Wood
2013-06-17 2:23 ` Lian Minghuan-b31939 [this message]
2013-06-18 0:18 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BE7329.8070304@freescale.com \
--to=b31939@freescale.com \
--cc=Minghuan.Lian@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r61911@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).