From: Lian Minghuan-b31939 <B31939@freescale.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Minghuan Lian <Minghuan.Lian@freescale.com>,
linuxppc-dev@lists.ozlabs.org,
Zang Roy-R61911 <r61911@freescale.com>
Subject: Re: [PATCH 3/5] powerpc/dts: update MSI bindings doc for MPIC v4.3
Date: Tue, 18 Jun 2013 10:49:19 +0800 [thread overview]
Message-ID: <51BFCAAF.1070400@freescale.com> (raw)
In-Reply-To: <1371516126.9073.16@snotra>
On 06/18/2013 08:42 AM, Scott Wood wrote:
> On 06/17/2013 07:28:07 PM, Scott Wood wrote:
>> On 06/17/2013 12:07:41 AM, Lian Minghuan-b31939 wrote:
>>>>> + compatible = "fsl,mpic-msi";
>>>>> + reg = <0x41600 0x200 0x44140 4>;
>>>>
>>>> Why 0x200?
>>>>
>>> [Minghuan] The offsets of the MSIA registers are from 0x41600 to
>>> 0x417ff, and the size is 0x200.
>>> offset 0x41600-0x4170 are MSIIRA1-7.
>>> 0x41720 is MSISRA,
>>> 0x41750 is MSIIR.
>>> The others are reserved.
>>
>> There is no MSIIRA on fsl,mpic-msi.
>
> Sigh, I was thinking of MSIIR1A -- which of course is distinct from
> both MSIIRA1 and MSIIRA. :-P
>
> So it's just a bug that pq3-mpic.dtsi has a length of 0x80?
[Minghuan] I am sorry, there is a typo.
offset 0x41600-0x4170 should be MSIRA0-7.
The MSI bank size is 0x200.
The MSIR 0-7 size is 0x80.
So the first region of 'reg' should indicate bank size or MSIR size?
I think it should be a bank size. So MSI driver can access MSISR and
MSIIR, and provide some new features in feature.
>
> -Scott
next prev parent reply other threads:[~2013-06-18 2:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 7:15 [PATCH 1/5] powerpc/dts: add MPIC v4.3 dts node Minghuan Lian
2013-06-14 7:15 ` [PATCH 2/5] powerpc/fsl_msi: add MSIIR1 support for MPIC v4.3 Minghuan Lian
2013-06-14 22:09 ` Scott Wood
2013-06-17 3:00 ` Lian Minghuan-b31939
2013-06-18 0:15 ` Scott Wood
2013-06-18 2:34 ` Lian Minghuan-b31939
2013-06-18 18:08 ` Scott Wood
2013-06-14 7:15 ` [PATCH 3/5] powerpc/dts: update MSI bindings doc " Minghuan Lian
2013-06-14 22:06 ` Scott Wood
2013-06-17 5:07 ` Lian Minghuan-b31939
2013-06-18 0:28 ` Scott Wood
2013-06-18 0:42 ` Scott Wood
2013-06-18 2:49 ` Lian Minghuan-b31939 [this message]
2013-06-18 16:21 ` Scott Wood
2013-06-14 7:15 ` [PATCH 4/5] powerpc/dts: remove msi-available-ranges property Minghuan Lian
2013-06-14 22:10 ` Scott Wood
2013-06-17 5:15 ` Lian Minghuan-b31939
2013-06-18 0:13 ` Scott Wood
2013-06-14 7:15 ` [PATCH 5/5] powerpc/fsl_msi: add 'msiregs' kernel parameter Minghuan Lian
2013-06-14 22:13 ` Scott Wood
2013-06-17 5:36 ` Lian Minghuan-b31939
2013-06-18 0:18 ` Scott Wood
2013-06-18 3:10 ` Lian Minghuan-b31939
2013-06-18 16:22 ` Scott Wood
2013-06-14 20:39 ` [PATCH 1/5] powerpc/dts: add MPIC v4.3 dts node Scott Wood
2013-06-14 21:53 ` Scott Wood
2013-06-17 2:23 ` Lian Minghuan-b31939
2013-06-18 0:18 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51BFCAAF.1070400@freescale.com \
--to=b31939@freescale.com \
--cc=Minghuan.Lian@freescale.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=r61911@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).