linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: Alexander Popov <a13xp0p0v88@gmail.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Anatolij Gustschin <agust@denx.de>,
	Grant Likely <grant.likely@linaro.org>,
	Chris Ball <cjb@laptop.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Timur Tabi <timur@tabi.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver
Date: Wed, 10 Jul 2013 08:57:06 -0500	[thread overview]
Message-ID: <51DD6832.1060707@gmail.com> (raw)
In-Reply-To: <20130710134624.GC2615@book.gsilab.sittig.org>

On 07/10/2013 08:46 AM, Gerhard Sittig wrote:
> On Wed, Jul 10, 2013 at 14:21 +0400, Alexander Popov wrote:
>>
>> This is SCLPC device driver for the Freescale MPC512x.
>> It is needed for Direct Memory Access to the devices on LocalPlus Bus.
>>
>> Signed-off-by: Alexander Popov <a13xp0p0v88@gmail.com>
>> ---
>>  arch/powerpc/boot/dts/mpc5121.dtsi            |   8 +-
>>  arch/powerpc/include/asm/mpc5121.h            |  32 ++
>>  arch/powerpc/platforms/512x/Kconfig           |   6 +
>>  arch/powerpc/platforms/512x/Makefile          |   1 +
>>  arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 485 ++++++++++++++++++++++++++
>>  5 files changed, 531 insertions(+), 1 deletion(-)
>>  create mode 100644 arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
>>
>> diff --git a/arch/powerpc/boot/dts/mpc5121.dtsi b/arch/powerpc/boot/dts/mpc5121.dtsi
>> index bd14c00..6e0b0c0 100644
>> --- a/arch/powerpc/boot/dts/mpc5121.dtsi
>> +++ b/arch/powerpc/boot/dts/mpc5121.dtsi
>> @@ -261,7 +261,13 @@
>>  		/* LocalPlus controller */
>>  		lpc@10000 {
>>  			compatible = "fsl,mpc5121-lpc";
>> -			reg = <0x10000 0x200>;
>> +			reg = <0x10000 0x100>;
>> +		};
>> +
>> +		sclpc@10100 {
>> +			compatible = "fsl,mpc512x-lpbfifo";

The binding needs to be documented.

Rob

  reply	other threads:[~2013-07-10 13:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-10 10:21 [V2 2/2] powerpc/512x: add LocalPlus Bus FIFO device driver Alexander Popov
2013-07-10 13:46 ` Gerhard Sittig
2013-07-10 13:57   ` Rob Herring [this message]
2013-07-10 14:01   ` Timur Tabi
2013-07-12 10:42   ` Alexander Popov
2013-07-17  9:03     ` Gerhard Sittig
2013-07-26  5:31       ` Alexander Popov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DD6832.1060707@gmail.com \
    --to=robherring2@gmail.com \
    --cc=a13xp0p0v88@gmail.com \
    --cc=agust@denx.de \
    --cc=benh@kernel.crashing.org \
    --cc=cjb@laptop.org \
    --cc=grant.likely@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=s.hauer@pengutronix.de \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).