linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm-ppc@vger.kernel.org,
	Alex Williamson <alex.williamson@redhat.com>,
	Paul Mackerras <paulus@samba.org>,
	linuxppc-dev@lists.ozlabs.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 6/8] KVM: PPC: Add support for multiple-TCE hcalls
Date: Thu, 11 Jul 2013 22:56:17 +1000	[thread overview]
Message-ID: <51DEAB71.8020109@ozlabs.ru> (raw)
In-Reply-To: <4133424D-B105-4CB1-A72A-4F47A6184DC7@suse.de>

On 07/11/2013 10:51 PM, Alexander Graf wrote:
> 
> On 11.07.2013, at 14:39, Benjamin Herrenschmidt wrote:
> 
>> On Thu, 2013-07-11 at 13:15 +0200, Alexander Graf wrote:
>>> And that's bad. Jeez, seriously. Don't argue this case. We enable new
>>> features individually unless we're 100% sure we can keep everything
>>> working. In this case an ENABLE_CAP doesn't hurt at all, because user
>>> space still needs to handle the hypercalls if it wants them anyways.
>>> But you get debugging for free for example.
>>
>> An ENABLE_CAP is utterly pointless. More bloat. But you seem to like
>> it :-)
> 

> I don't like bloat usually. But Alexey even had an #ifdef DEBUG in there
> to selectively disable in-kernel handling of multi-TCE. Not calling
> ENABLE_CAP would give him exactly that without ugly #ifdefs in the
> kernel.


No, it would not give m anithing. My ugly debug was to disable realmode
only and still leave virtual mode on, not to disable both real and virtual
modes. It is a lot easier to disable in kernel handling in QEMU.



-- 
Alexey

  reply	other threads:[~2013-07-11 12:56 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-06 15:06 [PATCH 0/8 v5] KVM: PPC: IOMMU in-kernel handling Alexey Kardashevskiy
2013-07-06 15:07 ` [PATCH 1/8] KVM: PPC: reserve a capability number for multitce support Alexey Kardashevskiy
2013-07-06 15:07 ` [PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO Alexey Kardashevskiy
2013-07-06 15:07 ` [PATCH 3/8] vfio: add external user support Alexey Kardashevskiy
2013-07-08 21:52   ` Alex Williamson
2013-07-09  5:40     ` Alexey Kardashevskiy
2013-07-09 14:08       ` Alex Williamson
2013-07-06 15:07 ` [PATCH 4/8] powerpc: Prepare to support kernel handling of IOMMU map/unmap Alexey Kardashevskiy
2013-07-08  1:33   ` Benjamin Herrenschmidt
2013-07-09 15:54     ` Alexander Graf
2013-07-06 15:07 ` [PATCH 5/8] powerpc: add real mode support for dma operations on powernv Alexey Kardashevskiy
2013-07-08  4:44   ` [PATCH v2] " Alexey Kardashevskiy
2013-07-08  7:20     ` Benjamin Herrenschmidt
2013-07-08  7:31       ` Alexey Kardashevskiy
2013-07-08  7:40         ` Benjamin Herrenschmidt
2013-07-09 16:02   ` [PATCH 5/8] " Alexander Graf
2013-07-10  3:17     ` Alexey Kardashevskiy
2013-07-10  3:37     ` Benjamin Herrenschmidt
2013-07-06 15:07 ` [PATCH 6/8] KVM: PPC: Add support for multiple-TCE hcalls Alexey Kardashevskiy
2013-07-09 17:02   ` Alexander Graf
2013-07-10  5:00     ` Alexey Kardashevskiy
2013-07-10 10:05       ` Alexander Graf
2013-07-11  5:12         ` Alexey Kardashevskiy
2013-07-11 10:11           ` Alexander Graf
2013-07-11 10:54             ` Alexey Kardashevskiy
2013-07-11 11:15               ` Alexander Graf
2013-07-11 12:39                 ` Benjamin Herrenschmidt
2013-07-11 12:51                   ` Alexander Graf
2013-07-11 12:56                     ` Alexey Kardashevskiy [this message]
2013-07-11 12:58                     ` Benjamin Herrenschmidt
2013-07-11 13:13                       ` Alexey Kardashevskiy
2013-07-11 13:21                         ` Alexander Graf
2013-07-11 12:40                 ` Benjamin Herrenschmidt
2013-07-11 12:38             ` Benjamin Herrenschmidt
2013-07-11 12:33           ` Benjamin Herrenschmidt
2013-07-11 13:11             ` Alexander Graf
2013-07-06 15:07 ` [PATCH 7/8] KVM: PPC: Add support for IOMMU in-kernel handling Alexey Kardashevskiy
2013-07-09 17:06   ` Alexander Graf
2013-07-06 15:07 ` [PATCH 8/8] KVM: PPC: Add hugepage " Alexey Kardashevskiy
2013-07-09 17:32   ` Alexander Graf
2013-07-09 23:29     ` Alexey Kardashevskiy
2013-07-10 10:33       ` Alexander Graf
2013-07-10 10:39         ` Benjamin Herrenschmidt
2013-07-10 10:40           ` Alexander Graf
2013-07-10 10:42             ` Alexander Graf
2013-07-11  8:57     ` Alexey Kardashevskiy
2013-07-11  9:52       ` Alexander Graf
2013-07-11 12:37         ` Benjamin Herrenschmidt
2013-07-11 12:50           ` Alexander Graf
2013-07-11 12:56             ` Benjamin Herrenschmidt
2013-07-11 13:41               ` chandrashekar shastri
2013-07-11 13:44                 ` Alexander Graf
2013-07-11 13:46                 ` Alexey Kardashevskiy
  -- strict thread matches above, loose matches on Subject: below --
2013-06-27  5:02 [PATCH 0/8 v4] KVM: PPC: " Alexey Kardashevskiy
2013-06-27  5:02 ` [PATCH 6/8] KVM: PPC: Add support for multiple-TCE hcalls Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51DEAB71.8020109@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).