From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Dongsheng Wang <dongsheng.wang@freescale.com>
Cc: rjw@sisk.pl, linuxppc-dev@lists.ozlabs.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpuidle: fix unremovable issue for module driver
Date: Tue, 30 Jul 2013 11:28:15 +0200 [thread overview]
Message-ID: <51F7872F.30101@linaro.org> (raw)
In-Reply-To: <1375167319-12821-1-git-send-email-dongsheng.wang@freescale.com>
On 07/30/2013 08:55 AM, Dongsheng Wang wrote:
> From: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> After __cpuidle_register_device, the cpu incs are added up, but decs
> are not, thus the module refcount is not match. So the module "exit"
> function can not be executed when we do remove operation. Move
> module_put into __cpuidle_register_device to fix it.
Sorry, I still don't get it :/
register->module_get
unregister->module_put
you change it by:
register->module_get
register->module_put
unregister->none
which is wrong.
Can you describe the problem you are facing ? (a bit more than "I can't
unload the module").
> Signed-off-by: Wang Dongsheng <dongsheng.wang@freescale.com>
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index d75040d..e964ada 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -351,11 +351,8 @@ EXPORT_SYMBOL_GPL(cpuidle_disable_device);
>
> static void __cpuidle_unregister_device(struct cpuidle_device *dev)
> {
> - struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev);
> -
> list_del(&dev->device_list);
> per_cpu(cpuidle_devices, dev->cpu) = NULL;
> - module_put(drv->owner);
> }
>
> static int __cpuidle_device_init(struct cpuidle_device *dev)
> @@ -384,6 +381,8 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
> per_cpu(cpuidle_devices, dev->cpu) = dev;
> list_add(&dev->device_list, &cpuidle_detected_devices);
>
> + module_put(drv->owner);
> +
> ret = cpuidle_coupled_register_device(dev);
> if (ret) {
> __cpuidle_unregister_device(dev);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2013-07-30 9:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 6:55 [PATCH] cpuidle: fix unremovable issue for module driver Dongsheng Wang
2013-07-30 9:28 ` Daniel Lezcano [this message]
2013-07-30 10:48 ` Wang Dongsheng-B40534
2013-07-30 11:19 ` Daniel Lezcano
2013-07-30 13:33 ` Rafael J. Wysocki
2013-07-31 23:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F7872F.30101@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=dongsheng.wang@freescale.com \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).